From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from am1outboundpool.messaging.microsoft.com (am1ehsobe001.messaging.microsoft.com [213.199.154.204]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "MSIT Machine Auth CA 2" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 874632C0100 for ; Wed, 14 Aug 2013 18:14:49 +1000 (EST) Date: Wed, 14 Aug 2013 16:14:47 +0800 From: Shawn Guo To: Nicolin Chen Subject: Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver Message-ID: <20130814081445.GC31141@S2101-09.ap.freescale.net> References: <1376308870-14232-1-git-send-email-b42378@freescale.com> <1376308870-14232-2-git-send-email-b42378@freescale.com> <20130814032658.GA16915@S2101-09.ap.freescale.net> <20130814053016.GF31651@MrMyself> <20130814063931.GB31141@S2101-09.ap.freescale.net> <20130814063444.GG31651@MrMyself> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <20130814063444.GG31651@MrMyself> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, lars@metafoo.de, linuxppc-dev@lists.ozlabs.org, timur@tabi.org, rob.herring@calxeda.com, broonie@kernel.org, p.zabel@pengutronix.de, Fabio Estevam List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Aug 14, 2013 at 02:34:45PM +0800, Nicolin Chen wrote: > On Wed, Aug 14, 2013 at 02:39:33PM +0800, Shawn Guo wrote: > > We only need to maintain those versions that require different > > programming model in the list. For example, if S/PDIF on Vybrid > > is completely compatible with imx6q one and uses the exactly same > > programming model, we do not need to maintain a compatible string > > for Vybrid S/PDIF at all. Instead, we only need to have something > > like below in Vybrid dts file, and S/PDIF driver will just work for it. > > > > compatible = "fsl,vf600-spdif", "fsl,imx6q-spdif"; > > > > Shawn > > Clear. Thank you for the explain. > > Then I think I can merely remain "fsl,imx6q-spdif" here, > because all other cases should be completely compatible > with this one. They are only different in the clock source > names list, which's already being specified in dts file. > > Please correct me if you think this still isn't proper. And we generally prefer to use the soc that firstly integrates the IP to name the compatible. For IMX series, I think imx35 is the one, so we would name it "fsl,imx35-spdif". Shawn