From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ch1outboundpool.messaging.microsoft.com (ch1ehsobe004.messaging.microsoft.com [216.32.181.184]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "MSIT Machine Auth CA 2" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 6F6C62C0154 for ; Thu, 15 Aug 2013 19:24:24 +1000 (EST) Date: Thu, 15 Aug 2013 17:24:30 +0800 From: Shawn Guo To: Nicolin Chen Subject: Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver Message-ID: <20130815092428.GI16915@S2101-09.ap.freescale.net> References: <1376308870-14232-1-git-send-email-b42378@freescale.com> <1376308870-14232-2-git-send-email-b42378@freescale.com> <20130814032658.GA16915@S2101-09.ap.freescale.net> <20130814053016.GF31651@MrMyself> <20130814063931.GB31141@S2101-09.ap.freescale.net> <20130814063444.GG31651@MrMyself> <20130814081445.GC31141@S2101-09.ap.freescale.net> <520BA687.4030905@wwwdotorg.org> <20130815021823.GA1846@MrMyself> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <20130815021823.GA1846@MrMyself> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, lars@metafoo.de, Stephen Warren , linuxppc-dev@lists.ozlabs.org, timur@tabi.org, rob.herring@calxeda.com, broonie@kernel.org, p.zabel@pengutronix.de, Fabio Estevam List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Aug 15, 2013 at 10:18:23AM +0800, Nicolin Chen wrote: > Hi Stephen, > > On Wed, Aug 14, 2013 at 09:47:19AM -0600, Stephen Warren wrote: > > If the clock source name list is different, then it needs a different > > compatible value, so that each compatible value can specify which clock > > names are required. > > > > Also, the compatible value itself should always include the exact HW > > that's present (most specific HW version), as well as any other HW it's > > compatible with. > > Thank you for the comments. Yes, I did so in v1-v3, but after rethinking > about the situation (Actually both the HW version and the clock mux itself > are same, just the clock sources connecting to the mux might be different), > so I decided to do this by abstracting the driver from those source info > and letting DT binding to pass such information. Because I think putting > the clock sources into the driver differed by compatible value would make > the driver more like SoC-specified, not the ideal way -- SoC-independent, > since the clock sources are based on SoC design, not on itself. +1 It's pretty much the differences at SoC integration level not the IP itself, and it just happens to be handled in a register of the IP. Shawn