From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tx2outboundpool.messaging.microsoft.com (tx2ehsobe005.messaging.microsoft.com [65.55.88.15]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "MSIT Machine Auth CA 2" (not verified)) by ozlabs.org (Postfix) with ESMTPS id AB8CB2C012C for ; Mon, 19 Aug 2013 20:21:26 +1000 (EST) Date: Mon, 19 Aug 2013 18:21:06 +0800 From: Nicolin Chen To: Mark Rutland Subject: Re: [PATCH v7 2/2] ASoC: fsl: Add S/PDIF machine driver Message-ID: <20130819102105.GC11402@MrMyself> References: <20130819092458.GE3719@e106331-lin.cambridge.arm.com> <20130819095042.GA11402@MrMyself> <20130819100143.GH3719@e106331-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <20130819100143.GH3719@e106331-lin.cambridge.arm.com> Cc: "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , "lars@metafoo.de" , "swarren@wwwdotorg.org" , "festevam@gmail.com" , "s.hauer@pengutronix.de" , "timur@tabi.org" , "rob.herring@calxeda.com" , "tomasz.figa@gmail.com" , "broonie@kernel.org" , "p.zabel@pengutronix.de" , "R65777@freescale.com" , "shawn.guo@linaro.org" , "linuxppc-dev@lists.ozlabs.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Aug 19, 2013 at 11:01:43AM +0100, Mark Rutland wrote: > > At least they are separate drivers as I mentioned in the commit comments. > > I'm not sure that the boundary of Linux drivers should necessarily > determine the way we carve up the description of IP blocks, though > presumably it's a pretty sensible way of carving it up or we wouldn't > have done it. I'm not sure if I understand your point correctly. But in fact the IP driver is not being carved up. The spdif-transmitter and spdif-receiver are basically dummy codec drivers. All the IP-related codes are implemented in fsl_spdif.c, the PATCH 1/2 you just reviewed. > Is there any public documentation on the i.MX S/PDIF hardware block(s)? http://cache.freescale.com/files/32bit/doc/ref_manual/IMX6DQRM.pdf Thank you, Nicolin