From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-x230.google.com (mail-pb0-x230.google.com [IPv6:2607:f8b0:400e:c01::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 0D0B82C00F5 for ; Wed, 11 Sep 2013 08:50:36 +1000 (EST) Received: by mail-pb0-f48.google.com with SMTP id ma3so8163003pbc.21 for ; Tue, 10 Sep 2013 15:50:32 -0700 (PDT) Sender: Guenter Roeck Date: Tue, 10 Sep 2013 15:50:29 -0700 From: Guenter Roeck To: Benjamin Herrenschmidt Subject: Re: powerpc allmodconfig build broken due to commit 15863ff3b (powerpc: Make chip-id information available to userspace) Message-ID: <20130910225029.GA26981@roeck-us.net> References: <522D163E.80106@roeck-us.net> <522E5FD5.40603@micron.com> <1378850569.4121.28.camel@pasglop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1378850569.4121.28.camel@pasglop> Cc: Asai Thambi S P , "linux-kernel@vger.kernel.org" , Vasant Hegde , Shivaprasad G Bhat , Paul Mackerras , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Sep 11, 2013 at 08:02:49AM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2013-09-09 at 16:55 -0700, Asai Thambi S P wrote: > > On 09/08/2013 5:28 PM, Guenter Roeck wrote: > > > Hi all, > > > > > > powerpc allmodconfig build on the latest upstream kernel results in: > > > > > > ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined! > > > > > > This is due to commit 15863ff3b (powerpc: Make chip-id information > > > available to userspace). > > > Not surprising, as cpu_to_chip_id() is not exported. > > > > > Apart from the above error, I have a concern on the patch, purely based on the commit message. > > (to be honest, I am not familiar with the ppc architecture) > > > > Commit message of 15863ff3b has the following text. > > > > ****************** > > So far "/sys/devices/system/cpu/cpuX/topology/physical_package_id" > > was always default (-1) on ppc64 architecture. > > > > Now, some systems have an ibm,chip-id property in the cpu nodes in > > the device tree. On these systems, we now use this information to > > display physical_package_id > > ****************** > > > > Shouldn't the new definition of "topology_physical_package_id" apply only to those systems supporting ibm,chip-id property? > > There should be no negative side effect (appart from the missing > EXPORT_SYMBOL of course). If the property is not found in the > device-tree, the new function returns -1, so it should work fine on all > systems. > Good. I submitted a patch doing just that yesterday or so. Hope you'll accept it ;). Thanks, Guenter