From: Vladimir Murzin <murzin.v@gmail.com>
To: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Cc: paulus@samba.org, tglx@linutronix.de,
linuxppc-dev@lists.ozlabs.org, chenhui.zhao@freescale.com,
srivatsa.bhat@linux.vnet.ibm.com
Subject: Re: [PATCH 1/3] powerpc: export cpu_to_chip_id
Date: Wed, 11 Sep 2013 18:03:02 +0200 [thread overview]
Message-ID: <20130911160255.GA1967@hp530> (raw)
In-Reply-To: <52300FB9.5020104@linux.vnet.ibm.com>
On Wed, Sep 11, 2013 at 12:07:45PM +0530, Vasant Hegde wrote:
> On 09/10/2013 10:08 PM, Vladimir Murzin wrote:
> > While cross-building for PPC64 I've got
> >
> Vladimir,
>
> Below commit ID fixes this issue.
Great! For whatever reason I thought _GPL is default policy for exported
symbols... but, never mind ;)
Sorry for the noise
Vladimir
>
> commit 256588fda10f2a712631f8a4e72641a66adebdb8
> Author: Guenter Roeck <linux@roeck-us.net>
> Date: Mon Sep 9 18:37:56 2013 -0700
>
> powerpc: Export cpu_to_chip_id() to fix build error
>
> -Vasant
>
> > ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!
> >
> > mtip32xx refer to topology_physical_package_id, which stands for
> > cpu_to_chip-id.
> >
> > Make cpu_to_chip-id (and topology_physical_package_id) available for
> > external users.
> >
> > Signed-off-by: Vladimir Murzin <murzin.v@gmail.com>
> > ---
> > arch/powerpc/kernel/smp.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
> > index 442d8e2..1d9c1c2 100644
> > --- a/arch/powerpc/kernel/smp.c
> > +++ b/arch/powerpc/kernel/smp.c
> > @@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu)
> > of_node_put(np);
> > return of_get_ibm_chip_id(np);
> > }
> > +EXPORT_SYMBOL_GPL(cpu_to_chip_id);
> >
> > /* Helper routines for cpu to core mapping */
> > int cpu_core_index_of_thread(int cpu)
> >
>
prev parent reply other threads:[~2013-09-11 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 16:38 [PATCH 1/3] powerpc: export cpu_to_chip_id Vladimir Murzin
2013-09-11 6:37 ` Vasant Hegde
2013-09-11 16:03 ` Vladimir Murzin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130911160255.GA1967@hp530 \
--to=murzin.v@gmail.com \
--cc=chenhui.zhao@freescale.com \
--cc=hegdevasant@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).