From: Vladimir Murzin <murzin.v@gmail.com>
To: Matt Evans <matt@ozlabs.org>
Cc: Michael Neuling <mikey@neuling.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"paulus@samba.org" <paulus@samba.org>
Subject: Re: [PATCH] powerpc: net: filter: fix DIVWU instruction opcode
Date: Thu, 12 Sep 2013 04:52:45 +0200 [thread overview]
Message-ID: <20130912025241.GA1869@hp530> (raw)
In-Reply-To: <79BD1567-A588-4977-BF11-C03045B55884@ozlabs.org>
On Thu, Sep 12, 2013 at 10:28:03AM +0930, Matt Evans wrote:
> On 12 Sep 2013, at 10:02, Michael Neuling <mikey@neuling.org> wrote:
>
> > Vladimir Murzin <murzin.v@gmail.com> wrote:
> >
> >> Currently DIVWU stands for *signed* divw opcode:
> >>
> >> 7d 2a 4b 96 divwu r9,r10,r9
> >> 7d 2a 4b d6 divw r9,r10,r9
> >>
> >> Use the *unsigned* divw opcode for DIVWU.
> >
> > This looks like it's in only used in the BPF JIT code.
> >
> > Matt, any chance you an ACK/NACK this?
>
> Sure, that looks sensible, thanks Vladimir.
>
> Acked-by: Matt Evans <matt@ozlabs.org>
>
Thanks!
Vladimir
> >
> > Mikey
> >
> >>
> >> Signed-off-by: Vladimir Murzin <murzin.v@gmail.com>
> >> ---
> >> arch/powerpc/include/asm/ppc-opcode.h | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/powerpc/include/asm/ppc-opcode.h b/arch/powerpc/include/asm/ppc-opcode.h
> >> index d7fe9f5..c91842c 100644
> >> --- a/arch/powerpc/include/asm/ppc-opcode.h
> >> +++ b/arch/powerpc/include/asm/ppc-opcode.h
> >> @@ -218,7 +218,7 @@
> >> #define PPC_INST_MULLW 0x7c0001d6
> >> #define PPC_INST_MULHWU 0x7c000016
> >> #define PPC_INST_MULLI 0x1c000000
> >> -#define PPC_INST_DIVWU 0x7c0003d6
> >> +#define PPC_INST_DIVWU 0x7c000396
> >> #define PPC_INST_RLWINM 0x54000000
> >> #define PPC_INST_RLDICR 0x78000004
> >> #define PPC_INST_SLW 0x7c000030
> >> --
> >> 1.7.10.4
> >>
prev parent reply other threads:[~2013-09-12 2:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 16:03 [PATCH] powerpc: net: filter: fix DIVWU instruction opcode Vladimir Murzin
2013-09-12 0:32 ` Michael Neuling
2013-09-12 0:58 ` Matt Evans
2013-09-12 2:52 ` Vladimir Murzin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130912025241.GA1869@hp530 \
--to=murzin.v@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matt@ozlabs.org \
--cc=mikey@neuling.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).