linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc/powernv: Reduce panic timeout from 180s to 10s
@ 2013-09-26 11:17 Anton Blanchard
  2013-10-01  8:39 ` Michael Ellerman
  0 siblings, 1 reply; 5+ messages in thread
From: Anton Blanchard @ 2013-09-26 11:17 UTC (permalink / raw)
  To: benh, paulus; +Cc: linuxppc-dev


We made this change to pseries in 2011 and I think it makes
sense to do the same on powernv.

Signed-off-by: Anton Blanchard <anton@samba.org>
---

Index: b/arch/powerpc/platforms/powernv/setup.c
===================================================================
--- a/arch/powerpc/platforms/powernv/setup.c
+++ b/arch/powerpc/platforms/powernv/setup.c
@@ -37,6 +37,8 @@
 
 static void __init pnv_setup_arch(void)
 {
+	panic_timeout = 10;
+
 	/* Initialize SMP */
 	pnv_smp_init();
 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc/powernv: Reduce panic timeout from 180s to 10s
  2013-09-26 11:17 [PATCH] powerpc/powernv: Reduce panic timeout from 180s to 10s Anton Blanchard
@ 2013-10-01  8:39 ` Michael Ellerman
  2013-10-08 21:52   ` Scott Wood
  0 siblings, 1 reply; 5+ messages in thread
From: Michael Ellerman @ 2013-10-01  8:39 UTC (permalink / raw)
  To: Anton Blanchard; +Cc: paulus, linuxppc-dev

On Thu, Sep 26, 2013 at 09:17:19PM +1000, Anton Blanchard wrote:
> 
> We made this change to pseries in 2011 and I think it makes
> sense to do the same on powernv.

I'd vote we set it to 10s for all 64-bit machines in
arch/powerpc/kernel/setup_64.c.

cheers

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc/powernv: Reduce panic timeout from 180s to 10s
  2013-10-01  8:39 ` Michael Ellerman
@ 2013-10-08 21:52   ` Scott Wood
  2013-10-08 23:56     ` Anton Blanchard
  0 siblings, 1 reply; 5+ messages in thread
From: Scott Wood @ 2013-10-08 21:52 UTC (permalink / raw)
  To: Michael Ellerman; +Cc: linuxppc-dev, paulus, Anton Blanchard

On Tue, 2013-10-01 at 18:39 +1000, Michael Ellerman wrote:
> On Thu, Sep 26, 2013 at 09:17:19PM +1000, Anton Blanchard wrote:
> > 
> > We made this change to pseries in 2011 and I think it makes
> > sense to do the same on powernv.
> 
> I'd vote we set it to 10s for all 64-bit machines in
> arch/powerpc/kernel/setup_64.c.

Why is 64-bit relevant?  And wouldn't such a short delay be a problem if
the crash is displayed on a monitor?

-Scott

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc/powernv: Reduce panic timeout from 180s to 10s
  2013-10-08 21:52   ` Scott Wood
@ 2013-10-08 23:56     ` Anton Blanchard
  0 siblings, 0 replies; 5+ messages in thread
From: Anton Blanchard @ 2013-10-08 23:56 UTC (permalink / raw)
  To: Scott Wood; +Cc: linuxppc-dev, paulus


> > > We made this change to pseries in 2011 and I think it makes
> > > sense to do the same on powernv.
> > 
> > I'd vote we set it to 10s for all 64-bit machines in
> > arch/powerpc/kernel/setup_64.c.
> 
> Why is 64-bit relevant?  And wouldn't such a short delay be a problem
> if the crash is displayed on a monitor?

That is why we made it pseries specific in the past. Almost all our
boxes are on a virtual console and the 3 minutes of pausing just hurt
our uptimes.

If other platform maintainers prefer to keep the 3 minute pause, then
we just change the PowerNV platform.

Anton

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] powerpc/powernv: Reduce panic timeout from 180s to 10s
  2014-04-30 21:29 ` Paul Mackerras
@ 2014-04-30 22:07   ` Anton Blanchard
  0 siblings, 0 replies; 5+ messages in thread
From: Anton Blanchard @ 2014-04-30 22:07 UTC (permalink / raw)
  To: Paul Mackerras, benh, Michael Ellerman; +Cc: linuxppc-dev

We've already dropped the default pseries timeout to 10s, do
the same for powernv.

Signed-off-by: Anton Blanchard <anton@samba.org>
---
 arch/powerpc/platforms/powernv/setup.c | 2 ++
 1 file changed, 2 insertions(+)

v2: fix the commit message as Paul pointed out

diff --git a/arch/powerpc/platforms/powernv/setup.c b/arch/powerpc/platforms/powernv/setup.c
index 23aab41..a789307 100644
--- a/arch/powerpc/platforms/powernv/setup.c
+++ b/arch/powerpc/platforms/powernv/setup.c
@@ -39,6 +39,8 @@
 
 static void __init pnv_setup_arch(void)
 {
+	set_arch_panic_timeout(10, ARCH_PANIC_TIMEOUT);
+
 	/* Initialize SMP */
 	pnv_smp_init();
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-04-30 22:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-26 11:17 [PATCH] powerpc/powernv: Reduce panic timeout from 180s to 10s Anton Blanchard
2013-10-01  8:39 ` Michael Ellerman
2013-10-08 21:52   ` Scott Wood
2013-10-08 23:56     ` Anton Blanchard
  -- strict thread matches above, loose matches on Subject: below --
2014-04-30 21:20 [PATCH] powerpc/powernv: Reduce pseries " Anton Blanchard
2014-04-30 21:29 ` Paul Mackerras
2014-04-30 22:07   ` [PATCH] powerpc/powernv: Reduce " Anton Blanchard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).