[PATCH] powerpc/powernv: Reduce panic timeout from 180s to 10s

[PATCH] powerpc/powernv: Reduce panic timeout from 180s to 10s

[Anton Blanchard]

We made this change to pseries in 2011 and I think it makes
sense to do the same on powernv.

Signed-off-by: Anton Blanchard <anton@samba.org>
---

Index: b/arch/powerpc/platforms/powernv/setup.c
===================================================================
--- a/arch/powerpc/platforms/powernv/setup.c
+++ b/arch/powerpc/platforms/powernv/setup.c
@@ -37,6 +37,8 @@
 
 static void __init pnv_setup_arch(void)
 {
+	panic_timeout = 10;
+
 	/* Initialize SMP */
 	pnv_smp_init();
 

Re: [PATCH] powerpc/powernv: Reduce panic timeout from 180s to 10s

[Michael Ellerman]

On Thu, Sep 26, 2013 at 09:17:19PM +1000, Anton Blanchard wrote:
> 
> We made this change to pseries in 2011 and I think it makes
> sense to do the same on powernv.

I'd vote we set it to 10s for all 64-bit machines in
arch/powerpc/kernel/setup_64.c.

cheers

Re: [PATCH] powerpc/powernv: Reduce panic timeout from 180s to 10s

[Scott Wood]

On Tue, 2013-10-01 at 18:39 +1000, Michael Ellerman wrote:
> On Thu, Sep 26, 2013 at 09:17:19PM +1000, Anton Blanchard wrote:
> > 
> > We made this change to pseries in 2011 and I think it makes
> > sense to do the same on powernv.
> 
> I'd vote we set it to 10s for all 64-bit machines in
> arch/powerpc/kernel/setup_64.c.

Why is 64-bit relevant?  And wouldn't such a short delay be a problem if
the crash is displayed on a monitor?

-Scott

Re: [PATCH] powerpc/powernv: Reduce panic timeout from 180s to 10s

[Anton Blanchard]

> > > We made this change to pseries in 2011 and I think it makes
> > > sense to do the same on powernv.
> > 
> > I'd vote we set it to 10s for all 64-bit machines in
> > arch/powerpc/kernel/setup_64.c.
> 
> Why is 64-bit relevant?  And wouldn't such a short delay be a problem
> if the crash is displayed on a monitor?

That is why we made it pseries specific in the past. Almost all our
boxes are on a virtual console and the 3 minutes of pausing just hurt
our uptimes.

If other platform maintainers prefer to keep the 3 minute pause, then
we just change the PowerNV platform.

Anton

[PATCH] powerpc/powernv: Reduce pseries panic timeout from 180s to 10s

[Anton Blanchard]

We've already dropped the default pseries timeout to 10s, do
the same for powernv.

Signed-off-by: Anton Blanchard <anton@samba.org>
---
 arch/powerpc/platforms/powernv/setup.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/powerpc/platforms/powernv/setup.c b/arch/powerpc/platforms/powernv/setup.c
index 23aab41..a789307 100644
--- a/arch/powerpc/platforms/powernv/setup.c
+++ b/arch/powerpc/platforms/powernv/setup.c
@@ -39,6 +39,8 @@
 
 static void __init pnv_setup_arch(void)
 {
+	set_arch_panic_timeout(10, ARCH_PANIC_TIMEOUT);
+
 	/* Initialize SMP */
 	pnv_smp_init();
 
-- 
1.9.1

Re: [PATCH] powerpc/powernv: Reduce pseries panic timeout from 180s to 10s

[Paul Mackerras]

On Thu, May 01, 2014 at 07:20:04AM +1000, Anton Blanchard wrote:
> We've already dropped the default pseries timeout to 10s, do
> the same for powernv.

Why is there "pseries" in the patch subject rather than "powernv"?

Paul.

[PATCH] powerpc/powernv: Reduce panic timeout from 180s to 10s

[Anton Blanchard]

We've already dropped the default pseries timeout to 10s, do
the same for powernv.

Signed-off-by: Anton Blanchard <anton@samba.org>
---
 arch/powerpc/platforms/powernv/setup.c | 2 ++
 1 file changed, 2 insertions(+)

v2: fix the commit message as Paul pointed out

diff --git a/arch/powerpc/platforms/powernv/setup.c b/arch/powerpc/platforms/powernv/setup.c
index 23aab41..a789307 100644
--- a/arch/powerpc/platforms/powernv/setup.c
+++ b/arch/powerpc/platforms/powernv/setup.c
@@ -39,6 +39,8 @@
 
 static void __init pnv_setup_arch(void)
 {
+	set_arch_panic_timeout(10, ARCH_PANIC_TIMEOUT);
+
 	/* Initialize SMP */
 	pnv_smp_init();
 
-- 
1.9.1