From: Michael Ellerman <michael@ellerman.id.au>
To: Alistair Popple <alistair@popple.id.au>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/2] iommu: Update platform initialisation of iommu to use it_page_shift
Date: Tue, 1 Oct 2013 14:12:29 +1000 [thread overview]
Message-ID: <20131001041228.GB17966@concordia> (raw)
In-Reply-To: <1380599650-9541-3-git-send-email-alistair@popple.id.au>
On Tue, Oct 01, 2013 at 01:54:10PM +1000, Alistair Popple wrote:
> This patch initialises the iommu page size used for vio, cell, powernv
> and pseries platforms to 4K. It has been boot tested on a pseries
> machine with vio.
This patch fixes the build errors introduced by the previous patch
right?
In which case you need to rework it so that you introduce the new
constants, use them everywhere, before removing the old constants. ie.
the build should never break.
cheers
next prev parent reply other threads:[~2013-10-01 4:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 3:54 [PATCH 0/2] iommu: Support pages size other than 4K Alistair Popple
2013-10-01 3:54 ` [PATCH 1/2] iommu: Add support for iommu page sizes " Alistair Popple
2013-10-01 3:54 ` [PATCH 2/2] iommu: Update platform initialisation of iommu to use it_page_shift Alistair Popple
2013-10-01 4:12 ` Michael Ellerman [this message]
2013-10-01 7:13 ` Alistair Popple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131001041228.GB17966@concordia \
--to=michael@ellerman.id.au \
--cc=alistair@popple.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).