From: Paul Mackerras <paulus@samba.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, agraf@suse.de,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] kvm: powerpc: book3s: Fix build break for BOOK3S_32
Date: Thu, 3 Oct 2013 14:14:15 +1000 [thread overview]
Message-ID: <20131003041415.GA2801@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <1380724724-12892-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
On Wed, Oct 02, 2013 at 08:08:44PM +0530, Aneesh Kumar K.V wrote:
> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
>
> This was introduced by 85a0d845d8bb5df5d2669416212f56cbe1474c6b
It's a good idea to give the headline of the commit as well as the ID.
I also like to trim the ID to 10 characters or so. So it should look
like this:
This was introduced by 85a0d845d8 ("KVM: PPC: Book3S PR: Allocate
kvm_vcpu structs from kvm_vcpu_cache").
> arch/powerpc/kvm/book3s_pr.c: In function 'kvmppc_core_vcpu_create':
> arch/powerpc/kvm/book3s_pr.c:1182:30: error: 'struct kvmppc_vcpu_book3s' has no member named 'shadow_vcpu'
> make[1]: *** [arch/powerpc/kvm/book3s_pr.o] Error 1
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Acked-by: Paul Mackerras <paulus@samba.org>
Paul.
next prev parent reply other threads:[~2013-10-03 4:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 14:38 [PATCH] kvm: powerpc: book3s: Fix build break for BOOK3S_32 Aneesh Kumar K.V
2013-10-03 4:14 ` Paul Mackerras [this message]
2013-10-04 12:23 ` Alexander Graf
2013-10-04 12:27 ` Alexander Graf
2013-10-04 12:35 ` Paul Mackerras
2013-10-04 13:00 ` Alexander Graf
2013-10-04 23:45 ` Paul Mackerras
2013-10-04 23:59 ` Alexander Graf
2013-10-04 14:24 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131003041415.GA2801@iris.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=agraf@suse.de \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).