From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ea0-f177.google.com (mail-ea0-f177.google.com [209.85.215.177]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 04F272C00B8 for ; Thu, 3 Oct 2013 18:39:38 +1000 (EST) Received: by mail-ea0-f177.google.com with SMTP id f15so902135eak.8 for ; Thu, 03 Oct 2013 01:39:34 -0700 (PDT) Date: Thu, 3 Oct 2013 11:39:32 +0300 From: Jack Morgenstein To: Alexander Gordeev Subject: Re: [PATCH RFC 46/77] mlx4: Update MSI/MSI-X interrupts enablement code Message-ID: <20131003113932.065b9b63@jpm-OptiPlex-GX620> In-Reply-To: References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: linux-mips@linux-mips.org, "VMware, Inc." , linux-nvme@lists.infradead.org, linux-ide@vger.kernel.org, eli@mellanox.com, linux-s390@vger.kernel.org, Andy King , linux-scsi@vger.kernel.org, linux-rdma@vger.kernel.org, x86@kernel.org, Ingo Molnar , linux-pci@vger.kernel.org, iss_storagedev@hp.com, linux-driver@qlogic.com, Tejun Heo , Bjorn Helgaas , Dan Williams , Jon Mason , ogerlitz@mellanox.com, Solarflare linux maintainers , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ralf Baechle , e1000-devel@lists.sourceforge.net, Martin Schwidefsky , linux390@de.ibm.com, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2 Oct 2013 12:49:02 +0200 Alexander Gordeev wrote: > As result of recent re-design of the MSI/MSI-X interrupts enabling > pattern this driver has to be updated to use the new technique to > obtain a optimal number of MSI/MSI-X interrupts required. > > Signed-off-by: Alexander Gordeev New review -- ACK (i.e., patch is OK), subject to acceptance of patches 05 and 07 of this patch set. I sent my previous review (NACK) when I was not yet aware that changes proposed were due to the two earlier patches (mentioned above) in the current patch set. The change log here should actually read something like the following: As a result of changes to the MSI/MSI_X enabling procedures, this driver must be modified in order to preserve its current msi/msi_x enablement logic. -Jack