From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e06smtp16.uk.ibm.com (e06smtp16.uk.ibm.com [195.75.94.112]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e06smtp16.uk.ibm.com", Issuer "GeoTrust SSL CA" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 09A212C00A0 for ; Fri, 4 Oct 2013 16:47:15 +1000 (EST) Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 4 Oct 2013 07:47:11 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 805B517D805A for ; Fri, 4 Oct 2013 07:47:26 +0100 (BST) Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by b06cxnps3075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r946ktW753608504 for ; Fri, 4 Oct 2013 06:46:55 GMT Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r946l5Di024113 for ; Fri, 4 Oct 2013 00:47:07 -0600 Date: Fri, 4 Oct 2013 08:47:05 +0200 From: Heiko Carstens To: Alexei Starovoitov Subject: Re: [PATCH v3 net-next] fix unsafe set_memory_rw from softirq Message-ID: <20131004064705.GA4143@osiris> References: <1380853446-30537-1-git-send-email-ast@plumgrid.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1380853446-30537-1-git-send-email-ast@plumgrid.com> Cc: Eric Dumazet , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Nicolas Dichtel , linux-s390@vger.kernel.org, Russell King , x86@kernel.org, James Morris , Ingo Molnar , Alexey Kuznetsov , "Paul E. McKenney" , Xi Wang , Matt Evans , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Stelian Nirlu , Nicolas Schichan , Hideaki YOSHIFUJI , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Mircea Gherzan , Daniel Borkmann , Martin Schwidefsky , linux390@de.ibm.com, linuxppc-dev@lists.ozlabs.org, Patrick McHardy List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Oct 03, 2013 at 07:24:06PM -0700, Alexei Starovoitov wrote: > diff --git a/arch/s390/net/bpf_jit_comp.c b/arch/s390/net/bpf_jit_comp.c > index 7092392..a5df511 100644 > --- a/arch/s390/net/bpf_jit_comp.c > +++ b/arch/s390/net/bpf_jit_comp.c > @@ -881,7 +881,9 @@ void bpf_jit_free(struct sk_filter *fp) > struct bpf_binary_header *header = (void *)addr; > > if (fp->bpf_func == sk_run_filter) > - return; > + goto free_filter; > set_memory_rw(addr, header->pages); > module_free(NULL, header); > +free_filter: > + kfree(fp); > } For the s390 part: Acked-by: Heiko Carstens