From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ee0-x236.google.com (mail-ee0-x236.google.com [IPv6:2a00:1450:4013:c00::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 47BFD2C009C for ; Tue, 8 Oct 2013 16:46:19 +1100 (EST) Received: by mail-ee0-f54.google.com with SMTP id e53so3752161eek.13 for ; Mon, 07 Oct 2013 22:46:14 -0700 (PDT) Sender: Ingo Molnar Date: Tue, 8 Oct 2013 07:46:10 +0200 From: Ingo Molnar To: Mark Salter Subject: Re: [PATCH v2 14/14] Kconfig cleanup (PARPORT_PC dependencies) Message-ID: <20131008054610.GE14353@gmail.com> References: <1381209030-351-1-git-send-email-msalter@redhat.com> <1381209030-351-15-git-send-email-msalter@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1381209030-351-15-git-send-email-msalter@redhat.com> Cc: linux-mips@linux-mips.org, linux-m68k@vger.kernel.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Guan Xuetao , Russell King , Helge Deller , x86@kernel.org, "James E.J. Bottomley" , Ingo Molnar , Geert Uytterhoeven , Fenghua Yu , microblaze-uclinux@itee.uq.edu.au, Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Richard Henderson , Michal Simek , Tony Luck , linux-parisc@vger.kernel.org, Vineet Gupta , linux-kernel@vger.kernel.org, Ralf Baechle , Paul Mundt , linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , * Mark Salter wrote: > Remove messy dependencies from PARPORT_PC by having it depend on one > Kconfig symbol (ARCH_MAY_HAVE_PC_PARPORT) and having architectures > which need it, select ARCH_MAY_HAVE_PC_PARPORT in arch/*/Kconfig. > New architectures are unlikely to need PARPORT_PC, so this avoids > having an ever growing list of architectures to exclude. Those > architectures which do select ARCH_MAY_HAVE_PC_PARPORT in this > patch are the ones which have an asm/parport.h (or use the generic > version). > > Signed-off-by: Mark Salter > CC: Richard Henderson > CC: linux-alpha@vger.kernel.org > CC: Vineet Gupta > CC: Russell King > CC: linux-arm-kernel@lists.infradead.org > CC: Tony Luck > CC: Fenghua Yu > CC: linux-ia64@vger.kernel.org > CC: Geert Uytterhoeven > CC: linux-m68k@lists.linux-m68k.org > CC: Michal Simek > CC: microblaze-uclinux@itee.uq.edu.au > CC: Ralf Baechle > CC: linux-mips@linux-mips.org > CC: "James E.J. Bottomley" > CC: Helge Deller > CC: linux-parisc@vger.kernel.org > CC: Benjamin Herrenschmidt > CC: Paul Mackerras > CC: linuxppc-dev@lists.ozlabs.org > CC: Paul Mundt > CC: linux-sh@vger.kernel.org > CC: "David S. Miller" > CC: sparclinux@vger.kernel.org > CC: Guan Xuetao > CC: Thomas Gleixner > CC: Ingo Molnar > CC: "H. Peter Anvin" > CC: x86@kernel.org > --- > drivers/parport/Kconfig | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/parport/Kconfig b/drivers/parport/Kconfig > index 70694ce..a079b18 100644 > --- a/drivers/parport/Kconfig > +++ b/drivers/parport/Kconfig > @@ -31,13 +31,17 @@ menuconfig PARPORT > > If unsure, say Y. > > +config ARCH_MAY_HAVE_PC_PARPORT > + bool > + help > + Select this config option from the architecture Kconfig if > + the architecture may have PC parallel port hardware. > + > if PARPORT > > config PARPORT_PC > tristate "PC-style hardware" > - depends on (!SPARC64 || PCI) && !SPARC32 && !M32R && !FRV && !S390 && \ > - (!M68K || ISA) && !MN10300 && !AVR32 && !BLACKFIN && \ > - !XTENSA && !CRIS && !H8300 > + depends on ARCH_MAY_HAVE_PC_PARPORT > > ---help--- > You should say Y here if you have a PC-style parallel port. All Since it's not a permission to have a parallel port but a possibility, I suspect the whole series needs a: s/MAY_HAVE/MIGHT_HAVE s/may have/might have Otherwise: Acked-by: Ingo Molnar Thanks, Ingo