From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.karo-electronics.de (mail.karo-electronics.de [81.173.242.67]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 72E712C00E4 for ; Mon, 21 Oct 2013 19:13:44 +1100 (EST) Date: Mon, 21 Oct 2013 10:11:17 +0200 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= To: Xiubo Li-B47053 Subject: Re: [PATCHv1 5/8] ASoC: sgtl5000: Revise the bugs about the sgt15000 codec. Message-ID: <20131021101117.5c0c71aa@ipc1.ka-ro> In-Reply-To: <1DD289F6464F0949A2FCA5AA6DC23F82866756@039-SN2MPN1-013.039d.mgd.msft.net> References: <1382000477-17304-1-git-send-email-Li.Xiubo@freescale.com> <1382000477-17304-6-git-send-email-Li.Xiubo@freescale.com> <20131017121721.43e1b34b@ipc1.ka-ro> <1DD289F6464F0949A2FCA5AA6DC23F82866756@039-SN2MPN1-013.039d.mgd.msft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "mark.rutland@arm.com" , "alsa-devel@alsa-project.org" , "linux-doc@vger.kernel.org" , "tiwai@suse.de" , Wang Huan-B18965 , "timur@tabi.org" , "perex@perex.cz" , Guo Shawn-R65073 , "linux@arm.linux.org.uk" , Chen Guangyu-B42378 , "linux-arm-kernel@lists.infradead.org" , "grant.likely@linaro.org" , "devicetree@vger.kernel.org" , "ian.campbell@citrix.com" , "pawel.moll@arm.com" , "swarren@wwwdotorg.org" , "rob.herring@calxeda.com" , "broonie@kernel.org" , "oskar@scara.com" , Estevam Fabio-R49496 , "lgirdwood@gmail.com" , "linux-kernel@vger.kernel.org" , "rob@landley.net" , Jin Zhengxiong-R64188 , "shawn.guo@linaro.org" , "linuxppc-dev@lists.ozlabs.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi, > > > diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c > > > index 1f4093f..4e2e4c9 100644 > > > --- a/sound/soc/codecs/sgtl5000.c > > > +++ b/sound/soc/codecs/sgtl5000.c > > > @@ -883,14 +883,19 @@ static int ldo_regulator_register(struct > > snd_soc_codec *codec, > > > struct regulator_init_data *init_data, > > > int voltage) > > > { > > > +#ifdef CONFIG_SND_SOC_FSL_SGTL5000 > > > + return 0; > > > +#else > > > dev_err(codec->dev, "this setup needs regulator support in the > > kernel\n"); > > > return -EINVAL; > > > +#endif > > > > > This looks wrong to me, as this will disable the error for unsolicited > > platforms in a multi arch kernel! > >=20 >=20 > The CONFIG_SND_SOC_FSL_SGTL5000 micro will be renamed to CONFIG_SND_SOC_F= SL_SGTL5000_VF610. > In VF610, there has not Power Manager Module, so whether the CONFIG_REGUL= ATOR is enable or=20 > Disabled, there will always some errors booting... >=20 Yes, but you are altering code that may be run on a different machine than VF610 in a multiarch kernel! You should have a RUNTIME check for the machine type if you need to do machine type specific stuff. Lothar Wa=C3=9Fmann --=20 ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstra=C3=9Fe 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Gesch=C3=A4ftsf=C3=BChrer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________