From: Paul Mackerras <paulus@samba.org>
To: Liu Ping Fan <kernelfans@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, Alexander Graf <agraf@suse.de>,
kvm-ppc@vger.kernel.org
Subject: Re: [PATCH 1/3] powerpc/kvm: simplify the entering logic for secondary thread
Date: Wed, 6 Nov 2013 16:01:00 +1100 [thread overview]
Message-ID: <20131106050100.GC14842@drongo> (raw)
In-Reply-To: <1383637364-14691-1-git-send-email-pingfank@linux.vnet.ibm.com>
On Tue, Nov 05, 2013 at 03:42:42PM +0800, Liu Ping Fan wrote:
> After the primary vcpu changes vcore_state to VCORE_RUNNING, there is
> very little chance to schedule to secondary vcpu. So if we change the
Why do you say there is very little chance to run the secondary vcpu?
> code sequence around set vcore_state to VCORE_RUNNING and disable
> preemption, we lost little. But we simplify the entering logi, based on
> the fact that if primary vcpu runs, the secondary vcpu can not be scheduled.
If a vcpu does a hypercall or something else that requires the host
(kernel or userspace) to do something, that can happen in the context
of the vcpu task for that vcpu. That vcpu task can run on another
core (unless it has been pinned). When it is finished we would like
the vcpu to continue executing in the guest as soon as possible. The
code that you remove in this patch enables that to happen without
having to wait until the other threads exit the guest. So I don't
think it is a good idea to remove this code.
Regards,
Paul.
next prev parent reply other threads:[~2013-11-06 5:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 7:42 [PATCH 1/3] powerpc/kvm: simplify the entering logic for secondary thread Liu Ping Fan
2013-11-05 7:42 ` [PATCH 2/3] powerpc/kvm: fix rare but potential deadlock scene Liu Ping Fan
2013-11-06 5:04 ` Paul Mackerras
2013-11-06 6:02 ` Liu ping fan
2013-11-06 11:18 ` Paul Mackerras
2013-11-07 2:36 ` Liu ping fan
2013-11-05 7:42 ` [PATCH 3/3] powerpc/kvm: remove redundant assignment Liu Ping Fan
2013-11-06 5:04 ` Paul Mackerras
2013-11-06 11:24 ` Alexander Graf
2013-11-06 19:58 ` Benjamin Herrenschmidt
2013-11-07 7:52 ` Alexander Graf
2013-11-07 7:55 ` Benjamin Herrenschmidt
2013-11-07 8:14 ` Alexander Graf
2013-11-07 8:36 ` Benjamin Herrenschmidt
2013-11-06 5:01 ` Paul Mackerras [this message]
2013-11-06 7:26 ` [PATCH 1/3] powerpc/kvm: simplify the entering logic for secondary thread Liu ping fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131106050100.GC14842@drongo \
--to=paulus@samba.org \
--cc=agraf@suse.de \
--cc=kernelfans@gmail.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).