linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: Michael Neuling <mikey@neuling.org>
Cc: Philippe Bergheaud <felix@linux.vnet.ibm.com>,
	Linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: memcpy optimization for 64bit LE
Date: Thu, 7 Nov 2013 13:07:03 +1100	[thread overview]
Message-ID: <20131107130703.482e8232@kryten> (raw)
In-Reply-To: <11438.1383718966@ale.ozlabs.ibm.com>


Hi,

> > Unaligned stores take alignment exceptions on POWER7 running in
> > little-endian. This is a dumb little-endian base memcpy that
> > prevents unaligned stores. It is replaced by the VMX memcpy at boot.
> 
> Is this any faster than the generic version?

Once booted the feature fixup code switches us over to the VMX copy
loops (which are already endian safe).

The question is what we do before that switch over. The base 64bit
memcpy takes alignment exceptions on POWER7 so we can't use it as is.
Fixing the causes of alignment exception would slow it down, because
we'd need to ensure all loads and stores are aligned either through
rotate tricks or bytewise loads and stores. Either would be bad for
all other 64bit platforms.

Anton

  parent reply	other threads:[~2013-11-07  2:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-05  8:38 [PATCH] powerpc: memcpy optimization for 64bit LE Philippe Bergheaud
2013-11-06  6:22 ` Michael Neuling
2013-11-06 10:21   ` Philippe Bergheaud
2013-11-07  2:10     ` Michael Neuling
2013-11-07 13:01       ` [PATCH v2] " Philippe Bergheaud
2013-11-07  2:07   ` Anton Blanchard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-04-29 23:10 [PATCH] " Anton Blanchard
2014-04-29 23:12 ` Anton Blanchard
2014-05-05 12:56 ` Philippe Bergheaud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131107130703.482e8232@kryten \
    --to=anton@samba.org \
    --cc=Linuxppc-dev@lists.ozlabs.org \
    --cc=felix@linux.vnet.ibm.com \
    --cc=mikey@neuling.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).