From: Paul Mackerras <paulus@samba.org>
To: Liu Ping Fan <kernelfans@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, Alexander Graf <agraf@suse.de>,
kvm-ppc@vger.kernel.org
Subject: Re: [PATCH v3 0/2] powerpc kvm: fix deadlock scene
Date: Fri, 8 Nov 2013 21:58:37 +1100 [thread overview]
Message-ID: <20131108105837.GC16470@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <1383895794-16164-1-git-send-email-pingfank@linux.vnet.ibm.com>
On Fri, Nov 08, 2013 at 03:29:52PM +0800, Liu Ping Fan wrote:
> v2->v3:
> introduce kvmppc_hv_unlock_hpte() to pair with kvmppc_hv_find_lock_hpte()
> and hide the preemption detail inside this pair from the callers
Actually, I preferred v2. This version seems a bit over-engineered.
Making a kvmppc_hv_unlock_hpte() is not such a bad idea, though I
would make it identical to the existing unlock_hpte() from
book3s_hv_rm_mmu.c, just in a header. I'm really not convinced about
putting the preempt_disable/enable inside the lock/unlock functions,
with the consequent need to pass in a 'vmode' parameter, given that
there is just one caller that needs to do the preempt_disable/enable.
Regards,
Paul.
next prev parent reply other threads:[~2013-11-08 10:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 7:29 [PATCH v3 0/2] powerpc kvm: fix deadlock scene Liu Ping Fan
2013-11-08 7:29 ` [PATCH v3 1/2] powerpc: kvm: pair kvmppc_hv_find_lock_hpte with _unlock_hpte Liu Ping Fan
2013-11-08 7:29 ` [PATCH v3 2/2] powerpc: kvm: fix rare but potential deadlock scene Liu Ping Fan
2013-11-08 10:58 ` Paul Mackerras [this message]
2013-11-11 1:02 ` [PATCH v3 0/2] powerpc kvm: fix " Liu ping fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131108105837.GC16470@iris.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=agraf@suse.de \
--cc=kernelfans@gmail.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).