From: Nicolin Chen <b42378@freescale.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, linux@arm.linux.org.uk,
pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
lgirdwood@gmail.com, swarren@wwwdotorg.org, timur@tabi.org,
rob.herring@calxeda.com, linux-kernel@vger.kernel.org,
broonie@kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: dts: imx: specify the value of audmux pinctrl instead of 0x80000000
Date: Fri, 15 Nov 2013 14:40:09 +0800 [thread overview]
Message-ID: <20131115064009.GD745@MrMyself> (raw)
In-Reply-To: <20131115064159.GG11014@S2101-09.ap.freescale.net>
On Fri, Nov 15, 2013 at 02:42:01PM +0800, Shawn Guo wrote:
> On Thu, Nov 14, 2013 at 07:07:09PM +0800, Nicolin Chen wrote:
> > We must specify the value of audmux pinctrl if we want to use pinctrl_pm().
> > Thus change bypass value 0x80000000 to what we exactly need.
> >
> > This patch also seperately unset PUE bit for TXD so that IOMUX won't pull
> > up/down the pin after turning into tristate. When we use SSI normal mode to
> > playback monaural audio via I2S signal, there'd be a pulled curve occur to
> > its signal at the second slot if setting PUE bit for TXD. And it will make
> > the second channel to play a constant noise. So by keeping the signal level
> > in the second slot, we can get a constant high level signal (-1) or a low
> > level one (0).
> >
> > Signed-off-by: Nicolin Chen <b42378@freescale.com>
> > ---
> > arch/arm/boot/dts/imx6qdl.dtsi | 22 +++++++++++-----------
> > 1 file changed, 11 insertions(+), 11 deletions(-)
>
> We have moved all pin groups settings into
> arch/arm/boot/dts/imx6qdl-pingrp.h. I just rebased and applied the
> patch. Please check my imx/dt branch and ensure I applied the changes
> correctly.
Simply perfect. Thank you.
Nicolin
---
next prev parent reply other threads:[~2013-11-15 6:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 11:07 [PATCH 0/2] Add monaural audio support for fsl_ssi.c Nicolin Chen
2013-11-14 11:07 ` [PATCH 1/2] ARM: dts: imx: specify the value of audmux pinctrl instead of 0x80000000 Nicolin Chen
2013-11-15 6:42 ` Shawn Guo
2013-11-15 6:40 ` Nicolin Chen [this message]
2013-11-14 11:07 ` [PATCH 2/2] ASoC: fsl_ssi: Add monaural audio support for non-ac97 interface Nicolin Chen
2013-11-15 12:21 ` Russell King - ARM Linux
2013-11-15 15:17 ` Nicolin Chen
2013-11-15 3:02 ` [PATCH 0/2] Add monaural audio support for fsl_ssi.c Shawn Guo
2013-11-15 2:59 ` Nicolin Chen
2013-11-15 3:22 ` Shawn Guo
2013-11-15 3:15 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131115064009.GD745@MrMyself \
--to=b42378@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=shawn.guo@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).