From: Paul Mackerras <paulus@samba.org>
To: Liu Ping Fan <qemulist@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, Alexander Graf <agraf@suse.de>,
kvm-ppc@vger.kernel.org
Subject: Re: [PATCH v2] powerpc: kvm: optimize "sc 1" as fast return
Date: Sat, 16 Nov 2013 18:00:56 +1100 [thread overview]
Message-ID: <20131116070056.GB18339@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <1384504501-19348-2-git-send-email-pingfank@linux.vnet.ibm.com>
On Fri, Nov 15, 2013 at 04:35:01PM +0800, Liu Ping Fan wrote:
>
> +sc_1_fast_return:
> + mtspr SPRN_SRR0,r10
> + mtspr SPRN_SRR1,r11
> + li r10, BOOK3S_INTERRUPT_SYSCALL
> + li r11, (MSR_ME << 1) | 1 /* synthesize MSR_SF | MSR_ME */
> + rotldi r11, r11, 63
You need a "mr r4, r9" instruction here, because fast_guest_return
needs the vcpu pointer in r4. Apart from that this looks fine.
> + b fast_guest_return
Paul.
next prev parent reply other threads:[~2013-11-16 7:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 8:35 [PATCH v4] powerpc: kvm: fix rare but potential deadlock scene Liu Ping Fan
2013-11-15 8:35 ` [PATCH v2] powerpc: kvm: optimize "sc 1" as fast return Liu Ping Fan
2013-11-16 7:00 ` Paul Mackerras [this message]
2013-11-18 1:06 ` liu ping fan
2013-11-16 6:55 ` [PATCH v4] powerpc: kvm: fix rare but potential deadlock scene Paul Mackerras
2013-11-18 21:32 ` Alexander Graf
2013-11-18 21:43 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131116070056.GB18339@iris.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=qemulist@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).