From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 20 Nov 2013 15:36:36 +1100 From: Paul Mackerras To: "Aneesh Kumar K.V" Subject: Re: [PATCH -V2 4/5] powerpc: mm: Only check for _PAGE_PRESENT in set_pte/pmd functions Message-ID: <20131120043636.GC5281@iris.ozlabs.ibm.com> References: <1384766893-10189-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1384766893-10189-5-git-send-email-aneesh.kumar@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1384766893-10189-5-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Cc: linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Nov 18, 2013 at 02:58:12PM +0530, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > We want to make sure we don't use these function when updating a pte > or pmd entry that have a valid hpte entry, because these functions > don't invalidate them. So limit the check to _PAGE_PRESENT bit. > Numafault core changes use these functions for updating _PAGE_NUMA bits. > That should be ok because when _PAGE_NUMA is set we can be sure that > hpte entries are not present. > > Signed-off-by: Aneesh Kumar K.V Acked-by: Paul Mackerras