From: Ralf Baechle <ralf@linux-mips.org>
To: Richard Zhu <r65037@freescale.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
linux-s390@vger.kernel.org, linux-ia64@vger.kernel.org,
Tony Luck <tony.luck@intel.com>,
Russell King <linux@arm.linux.org.uk>,
Jason Cooper <jason@lakedaemon.net>,
Fenghua Yu <fenghua.yu@intel.com>,
linux-mips@linux-mips.org, x86@kernel.org,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Chris Metcalf <cmetcalf@tilera.com>,
sparclinux@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Paul Mackerras <paulus@samba.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux390@de.ibm.com, Thomas Gleixner <tglx@linutronix.de>,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 24/34] PCI: use weak functions for MSI arch-specific functions
Date: Thu, 21 Nov 2013 18:39:33 +0100 [thread overview]
Message-ID: <20131121173933.GT10382@linux-mips.org> (raw)
In-Reply-To: <1384915853-31006-24-git-send-email-r65037@freescale.com>
On Wed, Nov 20, 2013 at 10:50:43AM +0800, Richard Zhu wrote:
Looking good,
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Nevertheless I'd again like to express that I'm not that fond of of the
increasing number of weak functions in the kernel. In the old days
things were such that when an a platform didn't provice a platform hook
or enable a default hook function, one would get a build error - an
unmistakable sign to the maintainer that something needs attention.
Weak functions mean default functions may result in subtly incorrect
operation. Been there, got bitten.
Ralf
next prev parent reply other threads:[~2013-11-21 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1384915853-31006-1-git-send-email-r65037@freescale.com>
2013-11-20 2:50 ` [PATCH 24/34] PCI: use weak functions for MSI arch-specific functions Richard Zhu
2013-11-21 17:39 ` Ralf Baechle [this message]
2013-11-21 19:08 ` Thomas Petazzoni
2013-11-21 19:33 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131121173933.GT10382@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=fenghua.yu@intel.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=jason@lakedaemon.net \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=r65037@freescale.com \
--cc=schwidefsky@de.ibm.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).