From: Anatolij Gustschin <agust@denx.de>
To: Gerhard Sittig <gsi@denx.de>
Cc: Scott Wood <scottwood@freescale.com>,
Mike Turquette <mturquette@linaro.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v6 07/17] clk: mpc5xxx: switch to COMMON_CLK, retire PPC_CLOCK
Date: Sat, 7 Dec 2013 10:42:37 +0100 [thread overview]
Message-ID: <20131207104237.0184de28@crub> (raw)
In-Reply-To: <1385851897-23475-8-git-send-email-gsi@denx.de>
On Sat, 30 Nov 2013 23:51:27 +0100
Gerhard Sittig <gsi@denx.de> wrote:
> the setup before the change was
> - arch/powerpc/Kconfig had the PPC_CLOCK option, off by default
> - depending on the PPC_CLOCK option the arch/powerpc/kernel/clock.c file
> was built, which implements the clk.h API but always returns -ENOSYS
> unless a platform registers specific callbacks
> - the MPC52xx platform selected PPC_CLOCK but did not register any
> callbacks, thus all clk.h API calls keep resulting in -ENOSYS errors
> (which is OK, all peripheral drivers deal with the situation)
> - the MPC512x platform selected PPC_CLOCK and registered specific
> callbacks implemented in arch/powerpc/platforms/512x/clock.c, thus
> provided real support for the clock API
> - no other powerpc platform did select PPC_CLOCK
>
> the situation after the change is
> - the MPC512x platform implements the COMMON_CLK interface, and thus the
> PPC_CLOCK approach in arch/powerpc/platforms/512x/clock.c has become
> obsolete
> - the MPC52xx platform still lacks genuine support for the clk.h API
> while this is not a change against the previous situation (the error
> code returned from COMMON_CLK stubs differs but every call still
> results in an error)
> - with all references gone, the arch/powerpc/kernel/clock.c wrapper and
> the PPC_CLOCK option have become obsolete, as did the clk_interface.h
> header file
>
> the switch from PPC_CLOCK to COMMON_CLK is done for all platforms within
> the same commit such that multiplatform kernels (the combination of 512x
> and 52xx within one executable) keep working
>
> Cc: Mike Turquette <mturquette@linaro.org>
> Cc: Anatolij Gustschin <agust@denx.de>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linuxppc-dev@lists.ozlabs.org
> Signed-off-by: Gerhard Sittig <gsi@denx.de>
> ---
> arch/powerpc/Kconfig | 5 -
> arch/powerpc/include/asm/clk_interface.h | 20 -
> arch/powerpc/kernel/Makefile | 1 -
> arch/powerpc/kernel/clock.c | 82 ----
> arch/powerpc/platforms/512x/Kconfig | 2 +-
> arch/powerpc/platforms/512x/Makefile | 1 -
> arch/powerpc/platforms/512x/clock.c | 754 ------------------------------
> arch/powerpc/platforms/52xx/Kconfig | 2 +-
> 8 files changed, 2 insertions(+), 865 deletions(-)
> delete mode 100644 arch/powerpc/include/asm/clk_interface.h
> delete mode 100644 arch/powerpc/kernel/clock.c
> delete mode 100644 arch/powerpc/platforms/512x/clock.c
applied to next. Thanks!
Anatolij
next prev parent reply other threads:[~2013-12-07 9:42 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-30 22:51 [PATCH v6 00/17] add COMMON_CLK support for PowerPC MPC512x Gerhard Sittig
2013-11-30 22:51 ` [PATCH v6 01/17] powerpc/fsl-pci: improve clock API use Gerhard Sittig
2013-11-30 22:51 ` [PATCH v6 02/17] dts: mpc512x: introduce dt-bindings/clock/ header Gerhard Sittig
2013-12-02 9:46 ` Mark Rutland
2013-12-02 14:25 ` Gerhard Sittig
2013-12-07 9:32 ` Anatolij Gustschin
2013-11-30 22:51 ` [PATCH v6 03/17] dts: mpc512x: add clock related device tree specs Gerhard Sittig
2013-12-07 9:34 ` Anatolij Gustschin
2013-11-30 22:51 ` [PATCH v6 04/17] clk: mpc512x: introduce COMMON_CLK for MPC512x (disabled) Gerhard Sittig
2013-12-07 9:37 ` Anatolij Gustschin
2013-11-30 22:51 ` [PATCH v6 05/17] clk: mpc512x: add backwards compat to the CCF code Gerhard Sittig
2013-12-07 9:40 ` Anatolij Gustschin
2013-11-30 22:51 ` [PATCH v6 06/17] dts: mpc512x: add clock specs for client lookups Gerhard Sittig
2013-12-07 9:41 ` Anatolij Gustschin
2013-11-30 22:51 ` [PATCH v6 07/17] clk: mpc5xxx: switch to COMMON_CLK, retire PPC_CLOCK Gerhard Sittig
2013-12-07 9:42 ` Anatolij Gustschin [this message]
2013-11-30 22:51 ` [PATCH v6 08/17] spi: mpc512x: adjust to OF based clock lookup Gerhard Sittig
2013-12-02 9:50 ` Mark Rutland
2013-12-02 15:10 ` Gerhard Sittig
2013-12-02 11:32 ` Mark Brown
2013-12-07 9:46 ` Anatolij Gustschin
2013-11-30 22:51 ` [PATCH v6 09/17] serial: mpc512x: adjust for " Gerhard Sittig
2013-12-05 0:55 ` Greg Kroah-Hartman
2013-12-07 9:49 ` Anatolij Gustschin
2013-11-30 22:51 ` [PATCH v6 10/17] serial: mpc512x: setup the PSC FIFO clock as well Gerhard Sittig
2013-12-05 0:55 ` Greg Kroah-Hartman
2013-12-07 9:51 ` Anatolij Gustschin
2013-11-30 22:51 ` [PATCH v6 11/17] USB: fsl-mph-dr-of: adjust for OF based clock lookup Gerhard Sittig
2013-12-05 0:55 ` Greg Kroah-Hartman
2013-12-07 9:53 ` Anatolij Gustschin
2013-11-30 22:51 ` [PATCH v6 12/17] mtd: mpc5121_nfc: " Gerhard Sittig
2013-12-07 9:55 ` Anatolij Gustschin
2013-11-30 22:51 ` [PATCH v6 13/17] [media] fsl-viu: " Gerhard Sittig
2013-12-07 9:55 ` Anatolij Gustschin
2013-11-30 22:51 ` [PATCH v6 14/17] net: can: mscan: adjust to common clock support for mpc512x Gerhard Sittig
2013-12-07 9:57 ` Anatolij Gustschin
2013-11-30 22:51 ` [PATCH v6 15/17] net: can: mscan: remove non-CCF code for MPC512x Gerhard Sittig
2013-12-07 9:58 ` Anatolij Gustschin
2013-11-30 22:51 ` [PATCH v6 16/17] powerpc/mpc512x: improve DIU related clock setup Gerhard Sittig
2013-12-07 9:59 ` Anatolij Gustschin
2013-11-30 22:51 ` [PATCH v6 17/17] clk: mpc512x: remove migration support workarounds Gerhard Sittig
2013-12-07 10:05 ` Anatolij Gustschin
2013-12-10 13:20 ` [PATCH v6 00/17] add COMMON_CLK support for PowerPC MPC512x Gerhard Sittig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131207104237.0184de28@crub \
--to=agust@denx.de \
--cc=gsi@denx.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mturquette@linaro.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).