* [PATCH] drivers/tty: ehv_bytechan fails to build as a module
@ 2013-12-09 5:03 Anton Blanchard
2014-01-04 19:15 ` Guenter Roeck
0 siblings, 1 reply; 4+ messages in thread
From: Anton Blanchard @ 2013-12-09 5:03 UTC (permalink / raw)
To: timur, gregkh, benh, paulus, dvaleev; +Cc: linuxppc-dev
ehv_bytechan is marked tristate but fails to build as a module:
drivers/tty/ehv_bytechan.c:363:1: error: type defaults to =E2=80=98int=E2=
=80=99 in declaration of =E2=80=98console_initcall=E2=80=99 [-Werror=3Dimpl=
icit-int]
It doesn't make much sense for a console driver to be built as
a module, so change it to a bool.
Signed-off-by: Anton Blanchard <anton@samba.org>
---
Index: b/drivers/tty/Kconfig
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- a/drivers/tty/Kconfig
+++ b/drivers/tty/Kconfig
@@ -366,7 +366,7 @@ config TRACE_SINK
"Trace data router for MIPI P1149.7 cJTAG standard".
=20
config PPC_EPAPR_HV_BYTECHAN
- tristate "ePAPR hypervisor byte channel driver"
+ bool "ePAPR hypervisor byte channel driver"
depends on PPC
select EPAPR_PARAVIRT
help
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: drivers/tty: ehv_bytechan fails to build as a module
2013-12-09 5:03 [PATCH] drivers/tty: ehv_bytechan fails to build as a module Anton Blanchard
@ 2014-01-04 19:15 ` Guenter Roeck
2014-01-08 1:21 ` Scott Wood
0 siblings, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2014-01-04 19:15 UTC (permalink / raw)
To: Anton Blanchard; +Cc: gregkh, dvaleev, paulus, linuxppc-dev, timur
On Mon, Dec 09, 2013 at 04:03:10PM +1100, Anton Blanchard wrote:
> ehv_bytechan is marked tristate but fails to build as a module:
>
> drivers/tty/ehv_bytechan.c:363:1: error: type defaults to ‘int’ in declaration of ‘console_initcall’ [-Werror=implicit-int]
>
> It doesn't make much sense for a console driver to be built as
> a module, so change it to a bool.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
>
Any comments on this patch ? The problem still causes powerpc:allmodconfig to
fail.
Guenter
> ---
>
>
> Index: b/drivers/tty/Kconfig
> ===================================================================
> --- a/drivers/tty/Kconfig
> +++ b/drivers/tty/Kconfig
> @@ -366,7 +366,7 @@ config TRACE_SINK
> "Trace data router for MIPI P1149.7 cJTAG standard".
>
> config PPC_EPAPR_HV_BYTECHAN
> - tristate "ePAPR hypervisor byte channel driver"
> + bool "ePAPR hypervisor byte channel driver"
> depends on PPC
> select EPAPR_PARAVIRT
> help
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: drivers/tty: ehv_bytechan fails to build as a module
2014-01-04 19:15 ` Guenter Roeck
@ 2014-01-08 1:21 ` Scott Wood
2014-01-08 1:29 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Scott Wood @ 2014-01-08 1:21 UTC (permalink / raw)
To: Guenter Roeck
Cc: gregkh, dvaleev, paulus, Anton Blanchard, linuxppc-dev, timur
On Sat, 2014-01-04 at 11:15 -0800, Guenter Roeck wrote:
> On Mon, Dec 09, 2013 at 04:03:10PM +1100, Anton Blanchard wrote:
> > ehv_bytechan is marked tristate but fails to build as a module:
> >
> > drivers/tty/ehv_bytechan.c:363:1: error: type defaults to ‘int’ in declaration of ‘console_initcall’ [-Werror=implicit-int]
> >
> > It doesn't make much sense for a console driver to be built as
> > a module, so change it to a bool.
> >
> > Signed-off-by: Anton Blanchard <anton@samba.org>
> >
>
> Any comments on this patch ? The problem still causes powerpc:allmodconfig to
> fail.
It's fine with me...
Greg, are you going to take this via tty.git or do you want it to go via
PPC?
-Scott
>
> Guenter
>
> > ---
> >
> >
> > Index: b/drivers/tty/Kconfig
> > ===================================================================
> > --- a/drivers/tty/Kconfig
> > +++ b/drivers/tty/Kconfig
> > @@ -366,7 +366,7 @@ config TRACE_SINK
> > "Trace data router for MIPI P1149.7 cJTAG standard".
> >
> > config PPC_EPAPR_HV_BYTECHAN
> > - tristate "ePAPR hypervisor byte channel driver"
> > + bool "ePAPR hypervisor byte channel driver"
> > depends on PPC
> > select EPAPR_PARAVIRT
> > help
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: drivers/tty: ehv_bytechan fails to build as a module
2014-01-08 1:21 ` Scott Wood
@ 2014-01-08 1:29 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2014-01-08 1:29 UTC (permalink / raw)
To: Scott Wood
Cc: dvaleev, paulus, Anton Blanchard, linuxppc-dev, timur,
Guenter Roeck
On Tue, Jan 07, 2014 at 07:21:03PM -0600, Scott Wood wrote:
> On Sat, 2014-01-04 at 11:15 -0800, Guenter Roeck wrote:
> > On Mon, Dec 09, 2013 at 04:03:10PM +1100, Anton Blanchard wrote:
> > > ehv_bytechan is marked tristate but fails to build as a module:
> > >
> > > drivers/tty/ehv_bytechan.c:363:1: error: type defaults to ‘int’ in declaration of ‘console_initcall’ [-Werror=implicit-int]
> > >
> > > It doesn't make much sense for a console driver to be built as
> > > a module, so change it to a bool.
> > >
> > > Signed-off-by: Anton Blanchard <anton@samba.org>
> > >
> >
> > Any comments on this patch ? The problem still causes powerpc:allmodconfig to
> > fail.
>
> It's fine with me...
>
> Greg, are you going to take this via tty.git or do you want it to go via
> PPC?
Feel free to take it through PPC.
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-01-08 1:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-09 5:03 [PATCH] drivers/tty: ehv_bytechan fails to build as a module Anton Blanchard
2014-01-04 19:15 ` Guenter Roeck
2014-01-08 1:21 ` Scott Wood
2014-01-08 1:29 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).