From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 50AD92C03B9 for ; Wed, 11 Dec 2013 09:49:08 +1100 (EST) Date: Tue, 10 Dec 2013 23:48:51 +0100 From: Peter Zijlstra To: Benjamin Herrenschmidt Subject: Re: [PATCH] KVM: PPC: Use schedule instead of cond_resched Message-ID: <20131210224851.GH13532@twins.programming.kicks-ass.net> References: <1386685284-3862-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1386708771.32037.73.camel@pasglop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1386708771.32037.73.camel@pasglop> Cc: "kvm@vger.kernel.org mailing list" , Alexander Graf , kvm-ppc@vger.kernel.org, Paul Mackerras , "Aneesh Kumar K.V" , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Dec 11, 2013 at 07:52:51AM +1100, Benjamin Herrenschmidt wrote: > On Tue, 2013-12-10 at 15:40 +0100, Alexander Graf wrote: > > On 10.12.2013, at 15:21, Aneesh Kumar K.V wrote: > > > > > From: "Aneesh Kumar K.V" > > > > > > We already checked need_resched. So we can call schedule directly > > > > > > Signed-off-by: Aneesh Kumar K.V > > > > The real fix for the issue you're seeing is > > > > https://lkml.org/lkml/2013/11/28/241 > > > > And is still not upstream.... Peter ? Yeah, I went on holidays and the patch just sat there. I'll prod Ingo into merging it.