From: Mark Brown <broonie@kernel.org>
To: Hou Zhiqiang <b48286@freescale.com>
Cc: linuxppc-dev@ozlabs.org, Mingkai.Hu@freescale.com,
scottwood@freescale.com, linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi/fsl-espi: Add Power Management support for eSPI controller
Date: Wed, 11 Dec 2013 13:39:48 +0000 [thread overview]
Message-ID: <20131211133948.GU11468@sirena.org.uk> (raw)
In-Reply-To: <1386749511-21904-1-git-send-email-b48286@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 583 bytes --]
On Wed, Dec 11, 2013 at 04:11:51PM +0800, Hou Zhiqiang wrote:
> +#ifdef CONFIG_PM
> +static int of_fsl_espi_suspend(struct device *dev, pm_message_t state)
This should be CONFIG_PM_SLEEP. I'd also expect to see a call to
spi_master_suspend() here (and similarly for resume) - it won't do
anything yet but it'd better for completeness in case we add extra
behaviour and looking at the driver it ought to be converted to
transfer_one_message anyway.
> +#ifdef CONFIG_PM
> + .suspend = of_fsl_espi_suspend,
> + .resume = of_fsl_espi_resume,
> +#endif
SET_SYSTEM_SLEEP_PM_OPS().
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-12-11 14:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 8:11 [PATCH] spi/fsl-espi: Add Power Management support for eSPI controller Hou Zhiqiang
2013-12-11 13:39 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131211133948.GU11468@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Mingkai.Hu@freescale.com \
--cc=b48286@freescale.com \
--cc=linux-spi@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).