* [PATCH 2/2] drivers: tty: Mark the function hvc_poll_init() as static in hvc_console.c [not found] <0d40902c95942d272a70b1d85b4e311d0cc7afa4.1387191158.git.rashika.kheria@gmail.com> @ 2013-12-16 11:01 ` Rashika Kheria 2013-12-16 11:11 ` Josh Triplett 0 siblings, 1 reply; 2+ messages in thread From: Rashika Kheria @ 2013-12-16 11:01 UTC (permalink / raw) To: linux-kernel Cc: Greg Kroah-Hartman, linuxppc-dev, josh, Rashika Kheria, Hendrik Brueckner, Jiri Slaby Mark the function hvc_poll_init() as static in hvc/hvc_console.c because it is not used outside this file. This eliminates the following warning in hvc/hvc_console.c: drivers/tty/hvc/hvc_console.c:791:5: warning: no previous prototype for ‘hvc_poll_init’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> --- drivers/tty/hvc/hvc_console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c index 9eba119..50b4688 100644 --- a/drivers/tty/hvc/hvc_console.c +++ b/drivers/tty/hvc/hvc_console.c @@ -788,7 +788,7 @@ static int hvc_tiocmset(struct tty_struct *tty, } #ifdef CONFIG_CONSOLE_POLL -int hvc_poll_init(struct tty_driver *driver, int line, char *options) +static int hvc_poll_init(struct tty_driver *driver, int line, char *options) { return 0; } -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] drivers: tty: Mark the function hvc_poll_init() as static in hvc_console.c 2013-12-16 11:01 ` [PATCH 2/2] drivers: tty: Mark the function hvc_poll_init() as static in hvc_console.c Rashika Kheria @ 2013-12-16 11:11 ` Josh Triplett 0 siblings, 0 replies; 2+ messages in thread From: Josh Triplett @ 2013-12-16 11:11 UTC (permalink / raw) To: Rashika Kheria Cc: Greg Kroah-Hartman, Hendrik Brueckner, Jiri Slaby, linux-kernel, linuxppc-dev On Mon, Dec 16, 2013 at 04:31:28PM +0530, Rashika Kheria wrote: > Mark the function hvc_poll_init() as static in hvc/hvc_console.c becaus= e > it is not used outside this file. >=20 > This eliminates the following warning in hvc/hvc_console.c: > drivers/tty/hvc/hvc_console.c:791:5: warning: no previous prototype for= =E2=80=98hvc_poll_init=E2=80=99 [-Wmissing-prototypes] >=20 > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> > drivers/tty/hvc/hvc_console.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_consol= e.c > index 9eba119..50b4688 100644 > --- a/drivers/tty/hvc/hvc_console.c > +++ b/drivers/tty/hvc/hvc_console.c > @@ -788,7 +788,7 @@ static int hvc_tiocmset(struct tty_struct *tty, > } > =20 > #ifdef CONFIG_CONSOLE_POLL > -int hvc_poll_init(struct tty_driver *driver, int line, char *options) > +static int hvc_poll_init(struct tty_driver *driver, int line, char *op= tions) > { > return 0; > } > --=20 > 1.7.9.5 >=20 ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-16 11:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <0d40902c95942d272a70b1d85b4e311d0cc7afa4.1387191158.git.rashika.kheria@gmail.com>
2013-12-16 11:01 ` [PATCH 2/2] drivers: tty: Mark the function hvc_poll_init() as static in hvc_console.c Rashika Kheria
2013-12-16 11:11 ` Josh Triplett
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).