From: Guenter Roeck <linux@roeck-us.net>
To: Anton Blanchard <anton@samba.org>
Cc: gregkh@linuxfoundation.org, dvaleev@suse.com, paulus@samba.org,
linuxppc-dev@lists.ozlabs.org, timur@freescale.com
Subject: Re: drivers/tty: ehv_bytechan fails to build as a module
Date: Sat, 4 Jan 2014 11:15:37 -0800 [thread overview]
Message-ID: <20140104191537.GA9051@roeck-us.net> (raw)
In-Reply-To: <20131209160310.7f81a1bc@kryten>
On Mon, Dec 09, 2013 at 04:03:10PM +1100, Anton Blanchard wrote:
> ehv_bytechan is marked tristate but fails to build as a module:
>
> drivers/tty/ehv_bytechan.c:363:1: error: type defaults to ‘int’ in declaration of ‘console_initcall’ [-Werror=implicit-int]
>
> It doesn't make much sense for a console driver to be built as
> a module, so change it to a bool.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
>
Any comments on this patch ? The problem still causes powerpc:allmodconfig to
fail.
Guenter
> ---
>
>
> Index: b/drivers/tty/Kconfig
> ===================================================================
> --- a/drivers/tty/Kconfig
> +++ b/drivers/tty/Kconfig
> @@ -366,7 +366,7 @@ config TRACE_SINK
> "Trace data router for MIPI P1149.7 cJTAG standard".
>
> config PPC_EPAPR_HV_BYTECHAN
> - tristate "ePAPR hypervisor byte channel driver"
> + bool "ePAPR hypervisor byte channel driver"
> depends on PPC
> select EPAPR_PARAVIRT
> help
next prev parent reply other threads:[~2014-01-04 19:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 5:03 [PATCH] drivers/tty: ehv_bytechan fails to build as a module Anton Blanchard
2014-01-04 19:15 ` Guenter Roeck [this message]
2014-01-08 1:21 ` Scott Wood
2014-01-08 1:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140104191537.GA9051@roeck-us.net \
--to=linux@roeck-us.net \
--cc=anton@samba.org \
--cc=dvaleev@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).