From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from collaborate-mta1.arm.com (fw-tnat.austin.arm.com [217.140.110.23]) by ozlabs.org (Postfix) with ESMTP id 5C7352C0078 for ; Tue, 28 Jan 2014 02:53:43 +1100 (EST) Date: Mon, 27 Jan 2014 15:43:15 +0000 From: Catalin Marinas To: Nicolas Pitre Subject: Re: [PATCH 2/9] ARM64: get rid of arch_cpu_idle_prepare() Message-ID: <20140127154315.GG32608@arm.com> References: <1390802904-28399-1-git-send-email-nicolas.pitre@linaro.org> <1390802904-28399-3-git-send-email-nicolas.pitre@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1390802904-28399-3-git-send-email-nicolas.pitre@linaro.org> Cc: "linaro-kernel@lists.linaro.org" , Russell King , "linux-sh@vger.kernel.org" , Peter Zijlstra , "linux-pm@vger.kernel.org" , Daniel Lezcano , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Paul Mundt , Thomas Gleixner , "linuxppc-dev@lists.ozlabs.org" , Ingo Molnar , "linux-arm-kernel@lists.infradead.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Jan 27, 2014 at 06:08:17AM +0000, Nicolas Pitre wrote: > ARM and ARM64 are the only two architectures implementing > arch_cpu_idle_prepare() simply to call local_fiq_enable(). > > We have secondary_start_kernel() already calling local_fiq_enable() and > this is done a second time in arch_cpu_idle_prepare() in that case. And > enabling FIQs has nothing to do with idling the CPU to start with. > > So let's introduce init_fiq_boot_cpu() to take care of FIQs on the boot > CPU and remove arch_cpu_idle_prepare(). This is now done a bit earlier > at late_initcall time but this shouldn't make a difference in practice > given that FIQs are not currently used on ARM64. > > Signed-off-by: Nicolas Pitre For arm64, we could simply remove any reference to FIQs. I'm not aware of anyone using them. -- Catalin