From: Greg KH <greg@kroah.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: paulus@samba.org, linuxppc-dev@lists.ozlabs.org,
stable@vger.kernel.org, Li Zhong <zhong@linux.vnet.ibm.com>
Subject: Re: [PATCH 2/2] Fix compile error of pgtable-ppc64.h
Date: Wed, 29 Jan 2014 10:45:44 -0800 [thread overview]
Message-ID: <20140129184544.GA23204@kroah.com> (raw)
In-Reply-To: <1390911762-5659-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
On Tue, Jan 28, 2014 at 05:52:42PM +0530, Aneesh Kumar K.V wrote:
> From: Li Zhong <zhong@linux.vnet.ibm.com>
>
> It seems that forward declaration couldn't work well with typedef, use
> struct spinlock directly to avoiding following build errors:
>
> In file included from include/linux/spinlock.h:81,
> from include/linux/seqlock.h:35,
> from include/linux/time.h:5,
> from include/uapi/linux/timex.h:56,
> from include/linux/timex.h:56,
> from include/linux/sched.h:17,
> from arch/powerpc/kernel/asm-offsets.c:17:
> include/linux/spinlock_types.h:76: error: redefinition of typedef 'spinlock_t'
> /root/linux-next/arch/powerpc/include/asm/pgtable-ppc64.h:563: note: previous declaration of 'spinlock_t' was here
>
> build fix for upstream SHA1: b3084f4db3aeb991c507ca774337c7e7893ed04f
> for 3.13 stable series
I don't understand, why is this needed? Is there a corrisponding patch
upstream that already does this? What went wrong with a "normal"
backport of the patch to 3.13?
confused,
greg k-h
next prev parent reply other threads:[~2014-01-29 21:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 12:22 [PATCH 1/2] powerpc/thp: Fix crash on mremap Aneesh Kumar K.V
2014-01-28 12:22 ` [PATCH 2/2] Fix compile error of pgtable-ppc64.h Aneesh Kumar K.V
2014-01-29 18:45 ` Greg KH [this message]
2014-01-29 22:57 ` Benjamin Herrenschmidt
2014-01-30 12:34 ` Greg KH
2014-01-30 17:38 ` Aneesh Kumar K.V
2014-01-30 17:55 ` Greg KH
2014-01-30 18:03 ` Aneesh Kumar K.V
2014-01-30 20:59 ` Benjamin Herrenschmidt
2014-01-30 22:37 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140129184544.GA23204@kroah.com \
--to=greg@kroah.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=stable@vger.kernel.org \
--cc=zhong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).