From: Greg KH <greg@kroah.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org, paulus@samba.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
stable@vger.kernel.org, Li Zhong <zhong@linux.vnet.ibm.com>
Subject: Re: [PATCH 2/2] Fix compile error of pgtable-ppc64.h
Date: Thu, 30 Jan 2014 04:34:57 -0800 [thread overview]
Message-ID: <20140130123457.GA6571@kroah.com> (raw)
In-Reply-To: <1391036256.8524.81.camel@pasglop>
On Thu, Jan 30, 2014 at 09:57:36AM +1100, Benjamin Herrenschmidt wrote:
> On Wed, 2014-01-29 at 10:45 -0800, Greg KH wrote:
> > On Tue, Jan 28, 2014 at 05:52:42PM +0530, Aneesh Kumar K.V wrote:
> > > From: Li Zhong <zhong@linux.vnet.ibm.com>
> > >
> > > It seems that forward declaration couldn't work well with typedef, use
> > > struct spinlock directly to avoiding following build errors:
> > >
> > > In file included from include/linux/spinlock.h:81,
> > > from include/linux/seqlock.h:35,
> > > from include/linux/time.h:5,
> > > from include/uapi/linux/timex.h:56,
> > > from include/linux/timex.h:56,
> > > from include/linux/sched.h:17,
> > > from arch/powerpc/kernel/asm-offsets.c:17:
> > > include/linux/spinlock_types.h:76: error: redefinition of typedef 'spinlock_t'
> > > /root/linux-next/arch/powerpc/include/asm/pgtable-ppc64.h:563: note: previous declaration of 'spinlock_t' was here
> > >
> > > build fix for upstream SHA1: b3084f4db3aeb991c507ca774337c7e7893ed04f
> > > for 3.13 stable series
> >
> > I don't understand, why is this needed? Is there a corrisponding patch
> > upstream that already does this? What went wrong with a "normal"
> > backport of the patch to 3.13?
>
> There's a corresponding patch in powerpc-next that I'm about to send to
> Linus today, but for the backport, the "fix" could be folded into the
> original offending patch.
Oh come on, you know better than to try to send me a patch that isn't in
Linus's tree already. Crap, I can't take that at all.
Send me the git commit id when it is in Linus's tree, otherwise I'm not
taking it.
And no, don't "fold in" anything, that's not ok either. I'll just go
drop this patch entirely from all of my -stable trees for now. Feel
free to resend them when all of the needed stuff is upstream.
greg k-h
next prev parent reply other threads:[~2014-01-30 12:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 12:22 [PATCH 1/2] powerpc/thp: Fix crash on mremap Aneesh Kumar K.V
2014-01-28 12:22 ` [PATCH 2/2] Fix compile error of pgtable-ppc64.h Aneesh Kumar K.V
2014-01-29 18:45 ` Greg KH
2014-01-29 22:57 ` Benjamin Herrenschmidt
2014-01-30 12:34 ` Greg KH [this message]
2014-01-30 17:38 ` Aneesh Kumar K.V
2014-01-30 17:55 ` Greg KH
2014-01-30 18:03 ` Aneesh Kumar K.V
2014-01-30 20:59 ` Benjamin Herrenschmidt
2014-01-30 22:37 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140130123457.GA6571@kroah.com \
--to=greg@kroah.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=stable@vger.kernel.org \
--cc=zhong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).