From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: In-Reply-To: <1392415338-16288-4-git-send-email-cody@linux.vnet.ibm.com> To: Cody P Schafer , Linux PPC , Greg Kroah-Hartman From: Michael Ellerman Subject: Re: [PATCH v2 03/11] sysfs: create bin_attributes under the requested group Message-Id: <20140225033327.214B82C022C@ozlabs.org> Date: Tue, 25 Feb 2014 14:33:27 +1100 (EST) Cc: Peter Zijlstra , LKML , Ingo Molnar , Paul Mackerras , Arnaldo Carvalho de Melo List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2014-14-02 at 22:02:07 UTC, Cody P Schafer wrote: > bin_attributes created/updated in create_files() (such as those listed > via (struct device).attribute_groups) were not placed under the > specified group, and instead appeared in the base kobj directory. > > Fix this by making bin_attributes use creating code similar to normal > attributes. > > A quick grep shows that no one is using bin_attrs in a named attribute > group yet, so we can do this without breaking anything in usespace. > > Note that I do not add is_visible() support to > bin_attributes, though that could be done as well. > > Signed-off-by: Cody P Schafer Greg has already taken this, so we'll consider that as good as an ack from him, unless he wants to give us one. cheers