* [PATCH] net/mlx4: Support shutdown() interface
@ 2014-03-04 7:35 Gavin Shan
2014-03-06 1:45 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Gavin Shan @ 2014-03-04 7:35 UTC (permalink / raw)
To: netdev, linuxppc-dev; +Cc: weiyang, amirv, davem, Gavin Shan
In kexec scenario, we failed to load the mlx4 driver in the
second kernel because the ownership bit was hold by the first
kernel without release correctly.
The patch adds shutdown() interface so that the ownership can
be released correctly in the first kernel. It also helps avoiding
EEH error happened during boot stage of the second kernel because
of undesired traffic, which can't be handled by hardware during
that stage on Power platform.
Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
Tested-by: Wei Yang <weiyang@linux.vnet.ibm.com>
---
drivers/net/ethernet/mellanox/mlx4/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
index d711158..5a6105f 100644
--- a/drivers/net/ethernet/mellanox/mlx4/main.c
+++ b/drivers/net/ethernet/mellanox/mlx4/main.c
@@ -2684,6 +2684,7 @@ static struct pci_driver mlx4_driver = {
.name = DRV_NAME,
.id_table = mlx4_pci_table,
.probe = mlx4_init_one,
+ .shutdown = mlx4_remove_one,
.remove = mlx4_remove_one,
.err_handler = &mlx4_err_handler,
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/mlx4: Support shutdown() interface
2014-03-04 7:35 [PATCH] net/mlx4: Support shutdown() interface Gavin Shan
@ 2014-03-06 1:45 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-03-06 1:45 UTC (permalink / raw)
To: shangw; +Cc: netdev, weiyang, amirv, linuxppc-dev
From: Gavin Shan <shangw@linux.vnet.ibm.com>
Date: Tue, 4 Mar 2014 15:35:20 +0800
> In kexec scenario, we failed to load the mlx4 driver in the
> second kernel because the ownership bit was hold by the first
> kernel without release correctly.
>
> The patch adds shutdown() interface so that the ownership can
> be released correctly in the first kernel. It also helps avoiding
> EEH error happened during boot stage of the second kernel because
> of undesired traffic, which can't be handled by hardware during
> that stage on Power platform.
>
> Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
> Tested-by: Wei Yang <weiyang@linux.vnet.ibm.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-06 1:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-04 7:35 [PATCH] net/mlx4: Support shutdown() interface Gavin Shan
2014-03-06 1:45 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).