From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tx2outboundpool.messaging.microsoft.com (tx2ehsobe002.messaging.microsoft.com [65.55.88.12]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id AC13D2C01AE for ; Wed, 5 Mar 2014 12:49:02 +1100 (EST) Date: Wed, 5 Mar 2014 09:48:39 +0800 From: Shawn Guo To: Gerhard Sittig Subject: Re: [PATCH 2/3] dts: mpc512x: adjust clock specs for FEC nodes Message-ID: <20140305014836.GC8784@S2101-09.ap.freescale.net> References: <1393237557-31406-1-git-send-email-gsi@denx.de> <1393237557-31406-2-git-send-email-gsi@denx.de> <20140303092231.GS3327@book.gsilab.sittig.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <20140303092231.GS3327@book.gsilab.sittig.org> Cc: Mark Rutland , devicetree@vger.kernel.org, Mike Turquette , Pawel Moll , Ian Campbell , Rob Herring , Anatolij Gustschin , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Mar 03, 2014 at 10:22:31AM +0100, Gerhard Sittig wrote: > On Mon, Feb 24, 2014 at 11:25 +0100, Gerhard Sittig wrote: > > > > a recent FEC binding document update that was motivated by i.MX > > development revealed that ARM and PowerPC implementations in Linux > > did not agree on the clock names to use for the FEC nodes > > > > change clock names from "per" to "ipg" in the FEC nodes of the > > mpc5121.dtsi include file such that the .dts specs comply with > > the common FEC binding > > > > this "incompatible" change does not break operation, because > > - COMMON_CLK support for MPC5121/23/25 and adjusted .dts files > > were only introduced in Linux v3.14-rc1, no mainline release > > provided these specs before > > - if this change won't make it for v3.14, the MPC512x CCF support > > provides full backwards compability, and keeps operating with > > device trees which lack clock specs or don't match in the names > > > > Signed-off-by: Gerhard Sittig > > ping > > Are there opinions about making PowerPC users of FEC use the same > clock names as ARM users do, to re-use (actually: keep sharing) > the FEC binding? The alternative would be to fragment the FEC > binding into several bindings for ARM and PowerPC, which I feel > would be undesirable, and is not necessary. As I already said, Documentation/devicetree/bindings/net/fsl-fec.txt was created specifically for i.MX FEC controller from day one. And even as of today, it doesn't serve PowerPC, because for example the property 'phy-mode' documented as required one is not required by PowerPC FEC. My opinion would be to patch fsl-fec.txt a little bit to make it clear that it's a binding doc for i.MX FEC, and create the other one for PowerPC FEC. This is the way less confusing to people and easier for binding maintenance. Shawn