From: Nicolin Chen <Guangyu.Chen@freescale.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
David Laight <David.Laight@ACULAB.COM>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: fsl_sai: Add isr to deal with error flag
Date: Thu, 27 Mar 2014 10:29:36 +0800 [thread overview]
Message-ID: <20140327022934.GA16197@MrMyself> (raw)
In-Reply-To: <20140327011424.GB30768@sirena.org.uk>
On Thu, Mar 27, 2014 at 01:14:24AM +0000, Mark Brown wrote:
> On Wed, Mar 26, 2014 at 11:59:53AM +0000, David Laight wrote:
> > From: Nicolin Chen
>
> > > + regmap_read(sai->regmap, FSL_SAI_TCSR, &xcsr);
> > > + regmap_write(sai->regmap, FSL_SAI_TCSR, xcsr);
>
> > Assuming these are 'write to clear' bits, you might want
> > to make the write (above) and all the traces (below)
> > conditional on the value being non-zero.
>
> The trace is already conditional? I'd also expect to see the driver
> only acknowledging sources it knows about and only reporting that the
> interrupt was handled if it saw one of them - right now all interrupts
> are unconditionally acknowleged.
Will revise it based on the comments from both of you.
Thank you.
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2014-03-27 2:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 11:48 [PATCH] ASoC: fsl_sai: Add isr to deal with error flag Nicolin Chen
2014-03-26 11:59 ` David Laight
2014-03-27 1:14 ` Mark Brown
2014-03-27 2:29 ` Nicolin Chen [this message]
2014-03-27 9:41 ` David Laight
2014-03-27 13:05 ` Mark Brown
2014-03-27 2:13 ` Li.Xiubo
2014-03-27 2:36 ` Nicolin Chen
2014-03-27 2:53 ` Li.Xiubo
2014-03-27 2:56 ` Nicolin Chen
2014-03-27 3:41 ` Li.Xiubo
2014-03-27 3:31 ` Nicolin Chen
2014-03-27 4:06 ` Li.Xiubo
2014-03-27 3:57 ` Nicolin Chen
2014-03-27 4:18 ` Li.Xiubo
2014-03-27 10:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140327022934.GA16197@MrMyself \
--to=guangyu.chen@freescale.com \
--cc=David.Laight@ACULAB.COM \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).