From: Anton Blanchard <anton@samba.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Cody P Schafer <cody@linux.vnet.ibm.com>,
cody+local@linux.vnet.ibm.com,
LKML <linux-kernel@vger.kernel.org>,
Michael Ellerman <michael@ellerman.id.au>,
David.Laight@aculab.com,
Linux PPC <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 1/2] fixup: "powerpc/perf: Add support for the hv 24x7 interface"
Date: Mon, 7 Apr 2014 11:22:36 +1000 [thread overview]
Message-ID: <20140407112236.3d65d99b@kryten> (raw)
In-Reply-To: <1396828110.3671.21.camel@pasglop>
Hi
> That's not much less awful... The message gives 0 informations about
> where it comes from .. what is it that couldn't obtain capabilities ?
Cody is at least using pr_fmt to give some information on what went
wrong:
[ 1.635040] hv-24x7: not a virtualized system, not enabling
[ 1.635079] hv-gpci: not a virtualized system, not enabling
I think this is way too chatty though. If every driver printed a couple
of lines we'd end up with thousands of useless lines in the dmesg.
I still would prefer to see these as pr_debug lines.
Anton
next prev parent reply other threads:[~2014-04-07 1:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 22:10 [PATCH 0/2] powerpc/perf: fixup 2 patches from the 24x7 series Cody P Schafer
2014-04-02 22:10 ` [PATCH 1/2] fixup: "powerpc/perf: Add support for the hv 24x7 interface" Cody P Schafer
2014-04-06 23:48 ` Benjamin Herrenschmidt
2014-04-07 1:22 ` Anton Blanchard [this message]
2014-04-02 22:10 ` [PATCH 2/2] fixup: "powerpc/perf: Add support for the hv gpci (get performance counter info) interface" Cody P Schafer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407112236.3d65d99b@kryten \
--to=anton@samba.org \
--cc=David.Laight@aculab.com \
--cc=benh@kernel.crashing.org \
--cc=cody+local@linux.vnet.ibm.com \
--cc=cody@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).