* [PATCH] powerpc: Fix error return in rtas_flash module init
@ 2014-04-14 11:23 Anton Blanchard
0 siblings, 0 replies; only message in thread
From: Anton Blanchard @ 2014-04-14 11:23 UTC (permalink / raw)
To: benh, paulus; +Cc: linuxppc-dev
module_init should return 0 or a negative errno.
Signed-off-by: Anton Blanchard <anton@samba.org>
---
diff --git a/arch/powerpc/kernel/rtas_flash.c b/arch/powerpc/kernel/rtas_flash.c
index 2f3cdb0..658e89d 100644
--- a/arch/powerpc/kernel/rtas_flash.c
+++ b/arch/powerpc/kernel/rtas_flash.c
@@ -705,7 +705,7 @@ static int __init rtas_flash_init(void)
if (rtas_token("ibm,update-flash-64-and-reboot") ==
RTAS_UNKNOWN_SERVICE) {
pr_info("rtas_flash: no firmware flash support\n");
- return 1;
+ return -EINVAL;
}
rtas_validate_flash_data.buf = kzalloc(VALIDATE_BUF_SIZE, GFP_KERNEL);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-04-14 11:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-14 11:23 [PATCH] powerpc: Fix error return in rtas_flash module init Anton Blanchard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).