From: Andrew Morton <akpm@linux-foundation.org>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: linux-arch@vger.kernel.org, x86@kernel.org, riel@redhat.com,
Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
dave.hansen@intel.com, peterz@infradead.org,
Rusty Russell <rusty@rustcorp.com.au>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
ak@linux.intel.com, paulus@samba.org, mgorman@suse.de,
linuxppc-dev@lists.ozlabs.org, mingo@kernel.org
Subject: Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc
Date: Wed, 21 May 2014 13:34:08 -0700 [thread overview]
Message-ID: <20140521133408.4d2f1a551e9652fb0e12265f@linux-foundation.org> (raw)
In-Reply-To: <20140521134027.263DDE009B@blue.fi.intel.com>
On Wed, 21 May 2014 16:40:27 +0300 (EEST) "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> wrote:
> > Or something. Can we please get some code commentary over
> > do_fault_around() describing this design decision and explaining the
> > reasoning behind it?
>
> I'll do this. But if do_fault_around() rework is needed, I want to do that
> first.
This sort of thing should be at least partially driven by observation
and I don't have the data for that. My seat of the pants feel is that
after the first fault, accesses at higher addresses are more
common/probable than accesses at lower addresses. In which case we
should see improvements by centering the window at some higher address
than the fault. Much instrumentation and downstream analysis is needed
and the returns will be pretty small!
But we don't need to do all that right now. Let's get the current
implementation wrapped up for 3.15: get the interface finalized (bytes,
not pages!) and get the current design decisions appropriately
documented.
next prev parent reply other threads:[~2014-05-21 20:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 9:28 [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc Madhavan Srinivasan
2014-05-08 9:28 ` [PATCH V4 1/2] mm: move FAULT_AROUND_ORDER to arch/ Madhavan Srinivasan
2014-05-08 9:28 ` [PATCH V4 2/2] powerpc/pseries: init fault_around_order for pseries Madhavan Srinivasan
2014-05-20 7:28 ` Andrew Morton
2014-05-20 8:03 ` Madhavan Srinivasan
2014-05-15 8:25 ` [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc Madhavan Srinivasan
2014-05-15 17:28 ` Hugh Dickins
2014-05-19 0:12 ` Rusty Russell
2014-05-19 3:05 ` Madhavan Srinivasan
2014-05-19 23:23 ` Hugh Dickins
2014-05-19 23:43 ` Andrew Morton
2014-05-20 0:44 ` Kirill A. Shutemov
2014-05-20 6:22 ` Rusty Russell
2014-05-20 7:32 ` Andrew Morton
2014-05-20 7:53 ` Madhavan Srinivasan
2014-05-20 10:27 ` Kirill A. Shutemov
2014-05-20 19:59 ` Andrew Morton
2014-05-21 13:40 ` Kirill A. Shutemov
2014-05-21 20:34 ` Andrew Morton [this message]
2014-05-23 12:28 ` Kirill A. Shutemov
2014-05-27 6:24 ` Madhavan Srinivasan
2014-05-27 10:21 ` Kirill A. Shutemov
2014-05-27 10:44 ` Madhavan Srinivasan
2014-05-20 1:14 ` Rusty Russell
2014-05-20 2:34 ` Hugh Dickins
2014-05-20 2:06 ` Madhavan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521133408.4d2f1a551e9652fb0e12265f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).