From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp06.au.ibm.com (e23smtp06.au.ibm.com [202.81.31.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id EC4151A05A0 for ; Thu, 22 May 2014 10:01:36 +1000 (EST) Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 22 May 2014 10:01:36 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id B04A13578047 for ; Thu, 22 May 2014 10:01:33 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s4M01I8745285424 for ; Thu, 22 May 2014 10:01:18 +1000 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s4M01X5O031391 for ; Thu, 22 May 2014 10:01:33 +1000 Date: Thu, 22 May 2014 10:01:32 +1000 From: Gavin Shan To: Alexander Graf Subject: Re: [PATCH v5 4/4] powerpc/eeh: Avoid event on passed PE Message-ID: <20140522000132.GA7392@shangw> References: <1400648623-9127-1-git-send-email-gwshan@linux.vnet.ibm.com> <1400648623-9127-5-git-send-email-gwshan@linux.vnet.ibm.com> <537CA667.2070906@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <537CA667.2070906@suse.de> Cc: aik@ozlabs.ru, Gavin Shan , kvm-ppc@vger.kernel.org, alex.williamson@redhat.com, qiudayu@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org Reply-To: Gavin Shan List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, May 21, 2014 at 03:13:11PM +0200, Alexander Graf wrote: > >On 21.05.14 07:03, Gavin Shan wrote: >>If we detects frozen state on PE that has been passed to guest, we >>needn't handle it. Instead, we rely on the guest to detect and recover >>it. The patch avoid EEH event on the frozen passed PE so that the guest >>can have chance to handle that. >> >>Signed-off-by: Gavin Shan >>--- >> arch/powerpc/kernel/eeh.c | 8 ++++++++ >> arch/powerpc/platforms/powernv/eeh-ioda.c | 3 ++- >> 2 files changed, 10 insertions(+), 1 deletion(-) >> >>diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c >>index 2aaf90e..25fd12d 100644 >>--- a/arch/powerpc/kernel/eeh.c >>+++ b/arch/powerpc/kernel/eeh.c >>@@ -400,6 +400,14 @@ int eeh_dev_check_failure(struct eeh_dev *edev) >> if (ret > 0) >> return ret; >>+ /* >>+ * If the PE has been passed to guest, we won't check the >>+ * state. Instead, let the guest handle it if the PE has > >What guest? The kernel doesn't care whether we use VFIO for a guest or not. > Ok. I'll not mention "guest" and "vfio" in next revision. Thanks, Gavin > >Alex > >>+ * been frozen. >>+ */ >>+ if (eeh_pe_passed(pe)) >>+ return 0; >>+ >> /* If we already have a pending isolation event for this >> * slot, we know it's bad already, we don't need to check. >> * Do this checking under a lock; as multiple PCI devices >>diff --git a/arch/powerpc/platforms/powernv/eeh-ioda.c b/arch/powerpc/platforms/powernv/eeh-ioda.c >>index 1b5982f..03a3ed2 100644 >>--- a/arch/powerpc/platforms/powernv/eeh-ioda.c >>+++ b/arch/powerpc/platforms/powernv/eeh-ioda.c >>@@ -890,7 +890,8 @@ static int ioda_eeh_next_error(struct eeh_pe **pe) >> opal_pci_eeh_freeze_clear(phb->opal_id, frozen_pe_no, >> OPAL_EEH_ACTION_CLEAR_FREEZE_ALL); >> ret = EEH_NEXT_ERR_NONE; >>- } else if ((*pe)->state & EEH_PE_ISOLATED) { >>+ } else if ((*pe)->state & EEH_PE_ISOLATED || >>+ eeh_pe_passed(*pe)) { >> ret = EEH_NEXT_ERR_NONE; >> } else { >> pr_err("EEH: Frozen PHB#%x-PE#%x (%s) detected\n", >