From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linuxppc-dev@ozlabs.org, Anton Blanchard <anton@au1.ibm.com>,
linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
michael@ellerman.id.au, Ulrich.Weigand@de.ibm.com,
Maynard Johnson <mpjohn@us.ibm.com>
Subject: Re: [PATCH 1/1] powerpc/perf: Adjust callchain based on DWARF debug
Date: Thu, 22 May 2014 10:09:55 -0700 [thread overview]
Message-ID: <20140522170955.GB6318@us.ibm.com> (raw)
In-Reply-To: <20140522100045.GA4789@krava.brq.redhat.com>
Jiri Olsa [jolsa@redhat.com] wrote:
|
| yep, that sounds more clear to me.. something like below?
|
| calling callchain_dup from within arch_adjust_callchain in case
| you want to change it and returning != 0 in this case, so
| we could free the new callchain
Agree.
|
| but it might be to much overhead in case you have the support to skip
| just one entry now right? is there a plan for more cleaning? ;)
Its only one entry AFACIT. No plans for other changes, so will rename
the function as you mention in the other message and will resend.
Thanks,
Sukadev
next prev parent reply other threads:[~2014-05-22 17:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 1:26 [PATCH 1/1] powerpc/perf: Adjust callchain based on DWARF debug Sukadev Bhattiprolu
2014-05-22 10:00 ` Jiri Olsa
2014-05-22 17:09 ` Sukadev Bhattiprolu [this message]
2014-05-22 10:04 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140522170955.GB6318@us.ibm.com \
--to=sukadev@linux.vnet.ibm.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=acme@kernel.org \
--cc=anton@au1.ibm.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=mpjohn@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).