From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Russell King <linux@arm.linux.org.uk>,
Peter Zijlstra <peterz@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Paul Mackerras <paulus@samba.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
'Guenter Roeck' <linux@roeck-us.net>
Subject: Re: [PATCH v2] sched: Fix compiler warnings
Date: Wed, 25 Jun 2014 17:52:59 +0200 [thread overview]
Message-ID: <20140625155259.GQ14781@pengutronix.de> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D17265D81@AcuExch.aculab.com>
Hello,
On Wed, Jun 25, 2014 at 03:40:28PM +0000, David Laight wrote:
> From: Guenter Roeck
> > Actually turns out one can use __attribute_const__, and it is
> >
> > static inline int __attribute_const__ cpu_corepower_flags(void)
> >
> > which turns out to be widely used.
> >
> > I'll change that and resubmit after testing.
>
> You don't need to tell the compiler that for an inline function.
I didn't check for the functions in question here, but in general your
statement is wrong.
For example:
static inline unsigned int __attribute_const__ read_cpuid_id(void)
{
return readl(BASEADDR_V7M_SCB + V7M_SCB_CPUID);
}
from arch/arm/include/asm/cputype.h. The V7M_SCB_CPUID register never
changes, but there is no way gcc can deduce that.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2014-06-25 15:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 1:05 [PATCH v2] sched: Fix compiler warnings Guenter Roeck
2014-06-25 1:23 ` Benjamin Herrenschmidt
2014-06-25 6:41 ` Vincent Guittot
2014-06-25 7:14 ` Uwe Kleine-König
2014-06-25 14:27 ` Guenter Roeck
2014-06-25 14:49 ` Uwe Kleine-König
2014-06-25 15:03 ` Guenter Roeck
2014-06-25 15:40 ` David Laight
2014-06-25 15:52 ` Uwe Kleine-König [this message]
2014-06-25 16:04 ` David Laight
2014-06-25 16:09 ` Guenter Roeck
2014-06-26 0:59 ` Stephen Rothwell
2014-06-26 3:27 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140625155259.GQ14781@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=David.Laight@ACULAB.COM \
--cc=dietmar.eggemann@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).