From: Scott Wood <scottwood@freescale.com>
To: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [3/3,v4] powerpc/t2080rdb: Add T2080RDB board support
Date: Wed, 25 Jun 2014 18:34:50 -0500 [thread overview]
Message-ID: <20140625233450.GA13860@home.buserror.net> (raw)
In-Reply-To: <1402481406-10830-3-git-send-email-Shengzhou.Liu@freescale.com>
On Wed, Jun 11, 2014 at 06:10:06PM +0800, Shengzhou Liu wrote:
> + i2c@0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x0>;
> +
> + sfp@50 {
> + compatible = "optics,sfp";
> + reg = <0x50>;
> + };
> + };
What is "sfp"? Please use generic node names when possible.
I'm not able to easily find what chip this is referring to by googling
"optics sfp". I suspect this compatible is too vague -- what is the
actual part number? Could you provide a URL to a description of the
chip?
If "optics" is the correct vendor name, it needs to go into
vendor-prefixes.txt.
-Scott
next prev parent reply other threads:[~2014-06-25 23:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 10:10 [PATCH 1/3 v4] powerpc/fsl-booke: Add support for T2080/T2081 SoC Shengzhou Liu
2014-06-11 10:10 ` [PATCH 2/3 v4] powerpc/fsl-booke: Add initial T208x QDS board support Shengzhou Liu
2014-06-25 23:23 ` [2/3,v4] " Scott Wood
2014-06-25 23:39 ` Scott Wood
2014-06-11 10:10 ` [PATCH 3/3 v4] powerpc/t2080rdb: Add T2080RDB " Shengzhou Liu
2014-06-25 23:34 ` Scott Wood [this message]
2014-07-07 10:26 ` [3/3,v4] " Shengzhou.Liu
2014-07-07 22:16 ` Scott Wood
2014-07-02 1:43 ` [1/3,v4] powerpc/fsl-booke: Add support for T2080/T2081 SoC Scott Wood
2014-07-02 22:39 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140625233450.GA13860@home.buserror.net \
--to=scottwood@freescale.com \
--cc=Shengzhou.Liu@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).