From: David Miller <davem@davemloft.net>
To: kda@linux-powerpc.org
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 2/2] powerpc: bpf: Fix the broken LD_VLAN_TAG_PRESENT test
Date: Fri, 27 Jun 2014 16:14:40 -0700 (PDT) [thread overview]
Message-ID: <20140627.161440.1789637356563737660.davem@davemloft.net> (raw)
In-Reply-To: <1403717697-3911-2-git-send-email-kda@linux-powerpc.org>
From: Denis Kirjanov <kda@linux-powerpc.org>
Date: Wed, 25 Jun 2014 21:34:57 +0400
> We have to return the boolean here if the tag presents
> or not, not just ANDing the TCI with the mask which results to:
>
> [ 709.412097] test_bpf: #18 LD_VLAN_TAG_PRESENT
> [ 709.412245] ret 4096 != 1
> [ 709.412332] ret 4096 != 1
> [ 709.412333] FAIL (2 times)
>
> Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
Applied.
next prev parent reply other threads:[~2014-06-27 23:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 17:34 [PATCH v2 1/2] powerpc: bpf: Use correct mask while accessing the VLAN tag Denis Kirjanov
2014-06-25 17:34 ` [PATCH v2 2/2] powerpc: bpf: Fix the broken LD_VLAN_TAG_PRESENT test Denis Kirjanov
2014-06-26 8:30 ` Michael Ellerman
2014-06-26 8:36 ` Daniel Borkmann
2014-06-27 5:08 ` Michael Ellerman
2014-06-27 9:46 ` Daniel Borkmann
2014-06-26 15:43 ` Denis Kirjanov
2014-06-27 23:14 ` David Miller [this message]
2014-06-27 23:14 ` [PATCH v2 1/2] powerpc: bpf: Use correct mask while accessing the VLAN tag David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140627.161440.1789637356563737660.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kda@linux-powerpc.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).