linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [1/3,v4] powerpc/fsl-booke: Add support for T2080/T2081 SoC
Date: Tue, 1 Jul 2014 20:43:24 -0500	[thread overview]
Message-ID: <20140702014324.GA21768@home.buserror.net> (raw)
In-Reply-To: <1402481406-10830-1-git-send-email-Shengzhou.Liu@freescale.com>

On Wed, Jun 11, 2014 at 06:10:04PM +0800, Shengzhou Liu wrote:
> +/* controller at 0x240000 */
> +&pci0 {
> +	compatible = "fsl,t2080-pcie", "fsl,qoriq-pcie";

None of your patches add "fsl,qoriq-pcie" to of_device_ids[] in
corenet_generic.c, so PCIe will not get probed.

Worse, if I add that string, the kernel hangs trying to access a PCIe
controller that is disabled by the RCW.  This is because U-Boot is
expecting "fsl,qoriq-pcie-v3.0", and thus can't find the disabled node in
order to delete it.

Did you test PCIe at all on these boards?

Did you test other peripherals?

-Scott

  parent reply	other threads:[~2014-07-02  1:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-11 10:10 [PATCH 1/3 v4] powerpc/fsl-booke: Add support for T2080/T2081 SoC Shengzhou Liu
2014-06-11 10:10 ` [PATCH 2/3 v4] powerpc/fsl-booke: Add initial T208x QDS board support Shengzhou Liu
2014-06-25 23:23   ` [2/3,v4] " Scott Wood
2014-06-25 23:39     ` Scott Wood
2014-06-11 10:10 ` [PATCH 3/3 v4] powerpc/t2080rdb: Add T2080RDB " Shengzhou Liu
2014-06-25 23:34   ` [3/3,v4] " Scott Wood
2014-07-07 10:26     ` Shengzhou.Liu
2014-07-07 22:16       ` Scott Wood
2014-07-02  1:43 ` Scott Wood [this message]
2014-07-02 22:39   ` [1/3,v4] powerpc/fsl-booke: Add support for T2080/T2081 SoC Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140702014324.GA21768@home.buserror.net \
    --to=scottwood@freescale.com \
    --cc=Shengzhou.Liu@freescale.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).