linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Tony Luck <tony.luck@gmail.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Anoop Thomas Mathew <atm@profoundis.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-tip-commits@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>,
	sparse@chrisli.org, rdunlap@infradead.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	anil.s.keshavamurthy@intel.com, Ingo Molnar <mingo@kernel.org>,
	Chris Wright <chrisw@sous-sol.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Gleixner <tglx@linutronix.de>,
	dl9pf@gmx.de, yrl.pp-manager.tt@hitachi.com, akataria@vmware.com,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: [PATCH v5 1/2] kprobes/powerpc: Fix arch_deref_entry_point to support ABIv2
Date: Wed, 02 Jul 2014 07:00:22 +0000	[thread overview]
Message-ID: <20140702070022.14689.7254.stgit@kbuild-fedora.novalocal> (raw)
In-Reply-To: <1404276081.7254.1.camel@concordia>

Since PowerPC64 ABIv2 doesn't have function descriptor
any more, arch_deref_entry_point(), which returns function
entry point from function descriptor, should be updated.

Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Anoop Thomas Mathew <atm@profoundis.com>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: linuxppc-dev@lists.ozlabs.org
---
 arch/powerpc/kernel/kprobes.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/kprobes.c b/arch/powerpc/kernel/kprobes.c
index 90fab64..72a1034 100644
--- a/arch/powerpc/kernel/kprobes.c
+++ b/arch/powerpc/kernel/kprobes.c
@@ -491,7 +491,12 @@ int __kprobes kprobe_exceptions_notify(struct notifier_block *self,
 	return ret;
 }
 
-#ifdef CONFIG_PPC64
+#if defined(CONFIG_PPC64) && (!defined(_CALL_ELF) || _CALL_ELF == 1)
+/*
+ * On PPC64 ABIv1 the function pointer actually points to the
+ * function's descriptor. The first entry in the descriptor is the
+ * address of the function text.
+ */
 unsigned long arch_deref_entry_point(void *entry)
 {
 	return ((func_descr_t *)entry)->entry;

  parent reply	other threads:[~2014-07-02  7:00 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-20  2:23 [PATCH v4] [BUGFIX] kprobes: Fix "Failed to find blacklist" error on ia64 and ppc64 Masami Hiramatsu
2014-06-30  3:14 ` Masami Hiramatsu
2014-06-30 11:36   ` Michael Ellerman
2014-07-01  2:21     ` Masami Hiramatsu
2014-07-02  4:41       ` Michael Ellerman
2014-07-02  6:39         ` Masami Hiramatsu
2014-07-02  6:56           ` Michael Ellerman
2014-07-02  7:16             ` Masami Hiramatsu
2014-07-02  7:00         ` Masami Hiramatsu [this message]
2014-07-02  7:18           ` [PATCH v5 1/2] kprobes/powerpc: Fix arch_deref_entry_point to support ABIv2 Masami Hiramatsu
2014-07-02  7:00         ` [PATCH v5 2/2] [BUGFIX] kprobes: Fix "Failed to find blacklist" error on ia64 and ppc64 Masami Hiramatsu
2014-07-08 12:07           ` Masami Hiramatsu
2014-07-14 17:17             ` Tony Luck
2014-07-15  2:11               ` Michael Ellerman
2014-07-15  2:24                 ` Masami Hiramatsu
2014-07-15  3:16                   ` Michael Ellerman
2014-07-15  3:19           ` Michael Ellerman
2014-07-15  7:16             ` Benjamin Herrenschmidt
2014-07-15 10:09               ` Masami Hiramatsu
2014-07-16 13:28                 ` Ingo Molnar
2014-07-17  7:10                   ` Masami Hiramatsu
2014-07-17  9:40                     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140702070022.14689.7254.stgit@kbuild-fedora.novalocal \
    --to=masami.hiramatsu.pt@hitachi.com \
    --cc=akataria@vmware.com \
    --cc=akpm@linux-foundation.org \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=arnd@arndb.de \
    --cc=atm@profoundis.com \
    --cc=benh@kernel.crashing.org \
    --cc=chrisw@sous-sol.org \
    --cc=davem@davemloft.net \
    --cc=dl9pf@gmx.de \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@kernel.org \
    --cc=paulus@samba.org \
    --cc=rdunlap@infradead.org \
    --cc=rusty@rustcorp.com.au \
    --cc=sparse@chrisli.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@gmail.com \
    --cc=torvalds@linux-foundation.org \
    --cc=yrl.pp-manager.tt@hitachi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).