linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: Tony Breeds <tony@bakeyournoodle.com>, grant.likely@secretlab.ca
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	linuxppc-dev@lists.ozlabs.org, Christoph Lameter <cl@gentwo.org>,
	Brian Hart <hartb@us.ibm.com>
Subject: Re: Kernel build issues after yesterdays merge by Linus
Date: Tue, 8 Jul 2014 11:06:42 +1000	[thread overview]
Message-ID: <20140708110642.1193b53e@kryten> (raw)
In-Reply-To: <20140613051559.GC19628@thor.bakeyournoodle.com>


Hi Tony,

> > Shows how much we use make install :) Below is a quick hack to get
> > you going but we should look at either fixing the Ubuntu
> > installkernel to handle extra optional args, or stop passing them
> > from the ppc64 kernel install.sh script.
> 
> It seems like passign the zImage files is probably wrong.  How about:

diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
index ccc25ed..146d898 100644
--- a/arch/powerpc/boot/Makefile
+++ b/arch/powerpc/boot/Makefile
@@ -390,7 +390,7 @@ $(obj)/zImage.initrd:	$(addprefix $(obj)/, $(initrd-y))
 	@rm -f $@; ln $< $@
 
 install: $(CONFIGURE) $(addprefix $(obj)/, $(image-y))
-	sh -x $(srctree)/$(src)/install.sh "$(KERNELRELEASE)" vmlinux System.map "$(INSTALL_PATH)" $^
+	sh -x $(srctree)/$(src)/install.sh "$(KERNELRELEASE)" vmlinux System.map "$(INSTALL_PATH)"
 
 # anything not in $(targets)
 clean-files += $(image-) $(initrd-) cuImage.* dtbImage.* treeImage.* \


Looks reasonable to me. Grant added this back in commit 29f1aff2 (powerpc:
Copy bootable images in the default install script) but the other archs have
gone in a different direction and created make zinstall targets.

Anton

      reply	other threads:[~2014-07-08  1:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-11 15:44 Kernel build issues after yesterdays merge by Linus Christoph Lameter
2014-06-11 20:26 ` Benjamin Herrenschmidt
2014-06-12 12:09 ` Anton Blanchard
2014-06-12 12:36   ` David Laight
2014-06-13  1:56     ` Christoph Lameter
2014-06-13  5:15   ` Tony Breeds
2014-07-08  1:06     ` Anton Blanchard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140708110642.1193b53e@kryten \
    --to=anton@samba.org \
    --cc=cl@gentwo.org \
    --cc=grant.likely@secretlab.ca \
    --cc=hartb@us.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=rusty@rustcorp.com.au \
    --cc=tony@bakeyournoodle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).