From: Nicolin Chen <Guangyu.Chen@freescale.com>
To: Varka Bhadram <varkabhadram@gmail.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, b42378@freescale.com,
timur@tabi.org, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk, tiwai@suse.de,
linux-kernel@vger.kernel.org, rdunlap@infradead.org,
b02247@freescale.com, lgirdwood@gmail.com, robh+dt@kernel.org,
perex@perex.cz, Nicolin Chen <nicoleotsuka@gmail.com>,
broonie@kernel.org, galak@codeaurora.org,
grant.likely@linaro.org, tklauser@distanz.ch,
shawn.guo@linaro.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers
Date: Fri, 25 Jul 2014 14:09:23 +0800 [thread overview]
Message-ID: <20140725060920.GA29433@MrMyself> (raw)
In-Reply-To: <53D1F686.30600@gmail.com>
On Fri, Jul 25, 2014 at 11:47:42AM +0530, Varka Bhadram wrote:
> Hi Nicolin,
>
> On 07/25/2014 11:24 AM, Nicolin Chen wrote:
> >Hi Varka,
> >
> > Regarding a point you suggested.
> >
> >On Fri, Jul 25, 2014 at 09:54:43AM +0530, Varka Bhadram wrote:
> >>On 07/25/2014 09:33 AM, Nicolin Chen wrote:
> >>(...)
> >>
> >>>+
> >>>+static const struct platform_device_id fsl_asrc_devtype[] = {
> >>>+ {
> >>>+ .name = "imx35-asrc",
> >>>+ .driver_data = IMX35_ASRC,
> >>>+ }, {
> >>>+ .name = "imx53-asrc",
> >>>+ .driver_data = IMX53_ASRC,
> >>>+ }, {
> >>>+ /* sentinel */
> >>>+ }
> >>>+};
> >>>+MODULE_DEVICE_TABLE(platform, fsl_asrc_devtype);
> >>>+
> >>>+static const struct of_device_id fsl_asrc_ids[] = {
> >>>+ {
> >>>+ .compatible = "fsl,imx35-asrc",
> >>>+ .data = &fsl_asrc_devtype[IMX35_ASRC],
> >>>+ }, {
> >>>+ .compatible = "fsl,imx53-asrc",
> >>>+ .data = &fsl_asrc_devtype[IMX53_ASRC],
> >>>+ }, {
> >>>+ /* sentinel */
> >>>+ }
> >>>+};
> >>>+MODULE_DEVICE_TABLE(of, fsl_asrc_ids);
> >>>+
> >>move these ids after probe/remove... every driver follows same thing...
> >Hmm.. fsl_asrc_ids is called in probe(), so it's probably not a good choice
> >to put them after probe/remove. And actually not every driver does so.
> >For example drivers/i2c/busses/i2c-s3c2410.c
> >
> >I think it should be okay to put here if it contains data.
>
> You are using these ids in the probe .Tt should be above the probe() so
> we can see of_match_device() directly...
> and also one more thing that the interrupt handler also would be immediately
> above the probe()
>
> ex:
> static irqreturn_t fsl_asrc_isr(int irq, void *dev_id)
> {
> ...
> }
>
> device ids..
>
> your_probe()
> {
> ...
> }
>
> your_remove()
> {
> ...
> }
>
> Now every driver that is coming following this style...
I see....
Will follow this style.
Thank you!
Nicolin
---
>
> If your not using device ids in probe then it would be like
>
> static irqreturn_t fsl_asrc_isr(int irq, void *dev_id)
> {
> ...
> }
>
> your_probe()
> {
> ...
> }
>
> your_remove()
> {
> ...
> }
>
> device ids..
>
> Thanks...
>
> --
> Regards,
> Varka Bhadram.
>
next prev parent reply other threads:[~2014-07-25 6:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 4:03 [PATCH v3 0/2] Add Freescale ASRC driver Nicolin Chen
2014-07-25 4:03 ` [PATCH v3 1/2] ARM: imx: Add the secondary request into the structure for imx-sdma Nicolin Chen
2014-07-25 4:03 ` [PATCH v3 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers Nicolin Chen
2014-07-25 4:24 ` Varka Bhadram
2014-07-25 5:30 ` Nicolin Chen
2014-07-25 5:54 ` Nicolin Chen
2014-07-25 6:17 ` Varka Bhadram
2014-07-25 6:09 ` Nicolin Chen [this message]
2014-07-29 9:46 ` Mark Rutland
2014-07-29 10:13 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140725060920.GA29433@MrMyself \
--to=guangyu.chen@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=b02247@freescale.com \
--cc=b42378@freescale.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=nicoleotsuka@gmail.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
--cc=tklauser@distanz.ch \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).