From: Nicolin Chen <Guangyu.Chen@freescale.com>
To: Varka Bhadram <varkabhadram@gmail.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, b42378@freescale.com,
timur@tabi.org, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk, tiwai@suse.de,
linux-kernel@vger.kernel.org, rdunlap@infradead.org,
b02247@freescale.com, lgirdwood@gmail.com, robh+dt@kernel.org,
perex@perex.cz, Nicolin Chen <nicoleotsuka@gmail.com>,
broonie@kernel.org, galak@codeaurora.org,
grant.likely@linaro.org, tklauser@distanz.ch,
shawn.guo@linaro.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v5 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers
Date: Fri, 25 Jul 2014 19:28:08 +0800 [thread overview]
Message-ID: <20140725112807.GA29852@MrMyself> (raw)
In-Reply-To: <53D240B3.8060203@gmail.com>
Hi Varka,
On Fri, Jul 25, 2014 at 05:04:11PM +0530, Varka Bhadram wrote:
> On 07/25/2014 02:16 PM, Nicolin Chen wrote:
> >The Asynchronous Sample Rate Converter (ASRC) converts the sampling rate of a
> >signal associated with an input clock into a signal associated with a different
> >output clock. The driver currently works as a Front End of DPCM with other Back
> >Ends DAI links such as ESAI<->CS42888 and SSI<->WM8962 and SAI. It converts the
> >original sample rate to a common rate supported by Back Ends for playback while
> >converts the common rate of Back Ends to a desired rate for capture. It has 3
> >pairs to support three different substreams within totally 10 channels.
> >
> >Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
> >---
> > .../devicetree/bindings/sound/fsl,asrc.txt | 60 ++
> > sound/soc/fsl/Kconfig | 9 +
> > sound/soc/fsl/Makefile | 2 +
> > sound/soc/fsl/fsl_asrc.c | 992 +++++++++++++++++++++
> > sound/soc/fsl/fsl_asrc.h | 461 ++++++++++
> > sound/soc/fsl/fsl_asrc_dma.c | 386 ++++++++
> > 6 files changed, 1910 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/sound/fsl,asrc.txt
> > create mode 100644 sound/soc/fsl/fsl_asrc.c
> > create mode 100644 sound/soc/fsl/fsl_asrc.h
> > create mode 100644 sound/soc/fsl/fsl_asrc_dma.c
> >
> >
> check patch warnings on this patch...
[...]
./scripts/checkpatch.pl --max-line-length=128 0002-ASoC-fsl_a....patch
total: 0 errors, 0 warnings, 1928 lines checked
0002-ASoC....patch has no obvious style problems and is ready for submission
[...]
I think there's no need to be so strict by wrapping all lines inside
80 characters, especially for those that will be less readable if being
wrapped and for those in header file.
Thank you
Nicolin
next prev parent reply other threads:[~2014-07-25 11:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 8:46 [PATCH v5 0/2] Add Freescale ASRC driver Nicolin Chen
2014-07-25 8:46 ` [PATCH v5 1/2] ARM: imx: Add the secondary request into the structure for imx-sdma Nicolin Chen
2014-07-25 8:46 ` [PATCH v5 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers Nicolin Chen
2014-07-25 11:34 ` Varka Bhadram
2014-07-25 11:28 ` Nicolin Chen [this message]
2014-07-25 12:05 ` Varka Bhadram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140725112807.GA29852@MrMyself \
--to=guangyu.chen@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=b02247@freescale.com \
--cc=b42378@freescale.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=nicoleotsuka@gmail.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
--cc=tklauser@distanz.ch \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).