From: Scott Wood <scottwood@freescale.com>
To: Priyanka Jain <Priyanka.Jain@freescale.com>
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Prabhakar Kushwaha <prabhakar@freescale.com>,
Poonam Aggrwal <poonam.aggrwal@freescale.com>
Subject: Re: [2/2] powerpc/fsl-booke: Add initial T1042RDB_PI board support
Date: Wed, 30 Jul 2014 15:12:51 -0500 [thread overview]
Message-ID: <20140730201250.GA29789@home.buserror.net> (raw)
In-Reply-To: <1404879851-2914-1-git-send-email-Priyanka.Jain@freescale.com>
On Wed, Jul 09, 2014 at 09:54:11AM +0530, Priyanka Jain wrote:
> diff --git a/arch/powerpc/boot/dts/t104xrdb.dtsi b/arch/powerpc/boot/dts/t104xrdb.dtsi
> index 9aaefa5..e7e765f 100644
> --- a/arch/powerpc/boot/dts/t104xrdb.dtsi
> +++ b/arch/powerpc/boot/dts/t104xrdb.dtsi
> @@ -57,7 +57,8 @@
> };
>
> cpld@3,0 {
> - compatible = "fsl,t1040rdb-cpld","fsl,t1042rdb-cpld";
> + compatible = "fsl,t1040rdb-cpld","fsl,t1042rdb-cpld",
> + "fsl,t1042rdb_pi-cpld";
> reg = <3 0 0x300>;
> };
> };
What's going on here? This file is used by all three boards. If you
need to distinguish one board's CPLD from another's, you'll have to do it
somewhere else. If the CPLDs are exactly the same and no distinction
needs to be made, then you don't need three compatible strings. Even
then, you may wish to specify the exact board as the first compatible
string, but again you'll need to patch that in elsewhere so that it
actually matches the board.
-Scott
next prev parent reply other threads:[~2014-07-30 20:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 4:24 [PATCH 2/2] powerpc/fsl-booke: Add initial T1042RDB_PI board support Priyanka Jain
2014-07-30 20:12 ` Scott Wood [this message]
2014-07-31 4:37 ` [2/2] " Priyanka Jain
2014-07-31 5:07 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140730201250.GA29789@home.buserror.net \
--to=scottwood@freescale.com \
--cc=Priyanka.Jain@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=poonam.aggrwal@freescale.com \
--cc=prabhakar@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).