From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 88BE01A01E6 for ; Thu, 31 Jul 2014 23:53:25 +1000 (EST) Date: Thu, 31 Jul 2014 15:53:33 +0200 From: Alexander Gordeev To: linux-kernel@vger.kernel.org, Michael Ellerman , Benjamin Herrenschmidt Subject: Re: [PATCH 1/2] PCI/MSI/PPC: Remove arch_msi_check_device() Message-ID: <20140731135333.GA10517@dhcp-26-207.brq.redhat.com> References: <18276ae8c0b212b8d40dfd186e1c84b8ae949525.1405160163.git.agordeev@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <18276ae8c0b212b8d40dfd186e1c84b8ae949525.1405160163.git.agordeev@redhat.com> Cc: linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, Jul 12, 2014 at 01:21:07PM +0200, Alexander Gordeev wrote: > PowerPC is the only architecture that makes use of hook > arch_msi_check_device() and does perform some checks to > figure out if MSI/MSI-X could be enabled for a device. > However, there are no reasons why those checks could not > be done within arch_setup_msi_irqs() hook. > > Moving MSI checks into arch_setup_msi_irqs() makes code > more readable and allows getting rid of unnecessary hook > arch_msi_check_device(). Michael, Ben, Any feedback? Thanks! -- Regards, Alexander Gordeev agordeev@redhat.com