linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Nicolin Chen <Guangyu.Chen@freescale.com>
To: Varka Bhadram <varkabhadram@gmail.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	alsa-devel@alsa-project.org, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, Li.Xiubo@freescale.com,
	b42378@freescale.com, b02247@freescale.com,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org, timur@tabi.org,
	Nicolin Chen <nicoleotsuka@gmail.com>,
	broonie@kernel.org, galak@codeaurora.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] ASoC: fsl_sai: Add asynchronous mode support
Date: Tue, 5 Aug 2014 19:07:36 +0800	[thread overview]
Message-ID: <20140805110735.GA16503@MrMyself> (raw)
In-Reply-To: <53E0B926.9010103@gmail.com>

Hi Varka,

On Tue, Aug 05, 2014 at 04:29:50PM +0530, Varka Bhadram wrote:
> >diff --git a/Documentation/devicetree/bindings/sound/fsl-sai.txt b/Documentation/devicetree/bindings/sound/fsl-sai.txt
> >index 0f4e238..77864f4 100644
> >--- a/Documentation/devicetree/bindings/sound/fsl-sai.txt
> >+++ b/Documentation/devicetree/bindings/sound/fsl-sai.txt
> >@@ -24,6 +24,22 @@ Required properties:
> >  - big-endian-data: If this property is absent, the little endian mode will
> >    be in use as default, or the big endian mode will be in use for all the
> >    fifo data.
> >+- fsl,sai-synchronous-rx: This is a boolean property. If present, indicating
> >+  that SAI will work in the synchronous mode (sync Tx with Rx) which means
> >+  both the transimitter and receiver will send and receive data by following
> >+  receiver's bit clocks and frame sync clocks.
> >+- fsl,sai-asynchronous: This is a boolean property. If present, indicating
> >+  that SAI will work in the asynchronous mode, which means both transimitter
> >+  and receiver will send and receive data by following their own bit clocks
> >+  and frame sync clocks separately.
> >
> Would be readable if it like this...
> 
> fsl,sai-synchronous-rx: This is a boolean property. If present, indicating
> 			that SAI will work in the synchronous mode (sync Tx with Rx) which means
> 			both the transimitter and receiver will send and receive data by following
> 			receiver's bit clocks and frame sync clocks.
> - fsl,sai-asynchronous: This is a boolean property. If present, indicating
> 			that SAI will work in the asynchronous mode, which means both transimitter
> 			and receiver will send and receive data by following their own bit clocks
> 			and frame sync clocks separately.

I agree, however, the doc was initialized in that format. Adding
indentations for these two appended lines makes the whole text
look weird. :(

Thank you,
Nicolin

  reply	other threads:[~2014-08-05 11:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-05  7:32 [PATCH] ASoC: fsl_sai: Add asynchronous mode support Nicolin Chen
2014-08-05 10:59 ` Varka Bhadram
2014-08-05 11:07   ` Nicolin Chen [this message]
2014-08-05 11:14     ` Varka Bhadram
2014-08-06  2:42       ` Nicolin Chen
2014-08-06 20:12         ` Mark Brown
2014-08-07  9:45 ` Mark Brown
2014-08-07  9:44   ` Nicolin Chen
2014-08-07 10:05     ` Mark Brown
2014-08-07 11:19 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140805110735.GA16503@MrMyself \
    --to=guangyu.chen@freescale.com \
    --cc=Li.Xiubo@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=b02247@freescale.com \
    --cc=b42378@freescale.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mark.rutland@arm.com \
    --cc=nicoleotsuka@gmail.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=timur@tabi.org \
    --cc=varkabhadram@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).